fix: add missing namespace for console in managed cluster #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdtsw
requested review from
lburgazzoli and
MarianMacik
and removed request for
ykaliuta and
ugiordan
lburgazzoli
reviewed
Jan 23, 2025
main.go
Outdated
| @@ -476,6 +476,7 @@ func getCommonCache(ctx context.Context, cli client.Client, platform cluster.Pla | |||
| if platform == cluster.ManagedRhoai { | |||
| namespaceConfigs["redhat-ods-monitoring"] = cache.Config{} | |||
| namespaceConfigs["redhat-ods-applications"] = cache.Config{} | |||
| namespaceConfigs["openshift-console"] = cache.Config{} | |||
There was a problem hiding this comment.
maybe use the NamespaceConsoleLink constant
- blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1552 +/- ##
=======================================
Coverage 19.84% 19.84%
=======================================
Files 159 159
Lines 10794 10794
=======================================
Hits 2142 2142
Misses 8424 8424
Partials 228 228 ☔ View full report in Codecov by Sentry. |
lburgazzoli
approved these changes
Jan 23, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lburgazzoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zdtsw
added a commit
to zdtsw-forking/opendatahub-operator
that referenced
this pull request
Jan 23, 2025
…b-io#1552) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit 28d0fa1)
zdtsw
added a commit
to zdtsw-forking/opendatahub-operator
that referenced
this pull request
Jan 23, 2025
…b-io#1552) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit 28d0fa1)
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit 28d0fa1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RHOAIENG-14787
How Has This Been Tested?
Screenshot or short clip
Merge criteria