Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup Monitoring's initialize action #1542

Merged

Conversation

lburgazzoli
Copy link
Contributor

@lburgazzoli lburgazzoli commented Jan 22, 2025

The Monitoring controller is initialized only when the platform is
managed, hence there's no need to conditionally add manifests

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

The Monitoring controller is initialized only when the platform is
managed, hence there's no need to conditionally add manifests
@lburgazzoli lburgazzoli requested review from zdtsw and ykaliuta and removed request for MarianMacik and Sara4994 January 22, 2025 09:14
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 19.70%. Comparing base (2258161) to head (b7dd5a3).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rvices/monitoring/monitoring_controller_actions.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1542      +/-   ##
==========================================
+ Coverage   19.69%   19.70%   +0.01%     
==========================================
  Files         160      160              
  Lines       10985    10979       -6     
==========================================
  Hits         2163     2163              
+ Misses       8594     8588       -6     
  Partials      228      228              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

MarianMacik pushed a commit to MarianMacik/opendatahub-operator that referenced this pull request Jan 22, 2025
…flux/component-updates/odh-codeflare-operator-v2-17

chore(deps): update odh-codeflare-operator-v2-17 to bd2519d
@openshift-merge-bot openshift-merge-bot bot merged commit 21eba1b into opendatahub-io:main Jan 22, 2025
10 checks passed
@lburgazzoli lburgazzoli deleted the monitoring-cleanup-init branch January 22, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants