e2e: add cleanup logic to kserve tests to ensure no KnativeServing is present in the cluster #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… present in the cluster
ykaliuta
reviewed
Jan 18, 2025
tests/e2e/kserve_test.go
Outdated
| @@ -26,6 +28,7 @@ func kserveTestSuite(t *testing.T) { | |||
| ComponentTestCtx: ct, | |||
| } | |||
|
|
|||
| t.Run("Validate environment", componentCtx.validateEnv) | |||
There was a problem hiding this comment.
May be it should be part of setUp()? I do not see a lot of sense to use assertions there.
There was a problem hiding this comment.
you mean in the kserveTestSuite ?
There was a problem hiding this comment.
I do not have strong opinion. It may make sense to limit to the particular test if it does not matter for others. Allows to skip unnecessary work if the test is skipped. On the other hand it may be part of general preparation of the environment. Originally I was thinking about one global place. There is one https://github.com/opendatahub-io/opendatahub-operator/blob/main/tests/e2e/helper_test.go#L459 which is called from creation suite. With the changes it also can be reconsidered.
There was a problem hiding this comment.
it make sense, I'll have a look
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1517 +/- ##
=======================================
Coverage 19.69% 19.69%
=======================================
Files 161 161
Lines 11102 11102
=======================================
Hits 2187 2187
Misses 8683 8683
Partials 232 232 ☔ View full report in Codecov by Sentry. |
ykaliuta
approved these changes
Jan 18, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 72443c5
into
opendatahub-io:main
10 checks passed
zdtsw
pushed a commit
to zdtsw-forking/opendatahub-operator
that referenced
this pull request
Feb 3, 2025
… present in the cluster (opendatahub-io#1517) * e2e: add cleanup logic to kserve tests to ensure no KnativeServing is present in the cluster * Fix findings * lint (cherry picked from commit 72443c5)
zdtsw
added a commit
that referenced
this pull request
Feb 4, 2025
* Fix typo in file name: pkg/utils/test/matchers/matechers.go -> pkg/utils/test/matchers/matchers.go (#1505) (cherry picked from commit 68c6cae) * e2e: improve testOwnedNamespacesAllExist by leveragin gomega's async assertions (#1509) When the e2e test suite starts, it may take a while for some of the owned namespace to become available and in such case the related test would fail, since it does not retry. This commit replace the current synchronous test with an asynchronous one. (cherry picked from commit c35c6c1) * Improve unit tests for jq's toType and byteToType (#1506) - Refactor the toType test to handle more cases - Add additional cases to toTypes test - Add a specific test for byteToType (cherry picked from commit e1457ab) * e2e: add cleanup logic to kserve tests to ensure no KnativeServing is present in the cluster (#1517) * e2e: add cleanup logic to kserve tests to ensure no KnativeServing is present in the cluster * Fix findings * lint (cherry picked from commit 72443c5) * Revert "e2e: add cleanup logic to kserve tests to ensure no KnativeServing is present in the cluster" (#1522) * Revert "e2e: add cleanup logic to kserve tests to ensure no KnativeServing is…" This reverts commit 72443c5. * Fix after rebase (cherry picked from commit 6a762ad) * Add support for dynamic template data computation in template rendering action (#1527) (cherry picked from commit bf3c108) * chore: remove generics from Reconcier and use PlatformObject as base object type (#1514) - remove generics from Reconciler struct as it is not needed - set PlatformObject as the base obnject that the Reconciler handles to ensure the reconciler can access to common objects fields (cherry picked from commit 94ac12c) * chore: remove unused structs and functions from controlelrs/status package (#1535) (cherry picked from commit 614fea1) * chore: remove unused code (#1543) * chore: remove unused TrimToRFC1123Name function * chore: remove unused pkg/cluster/roles functions * chore: remove unused pkg/cluster/resources functions (cherry picked from commit 8c7fef2) * chore: use constants from the status package where possible (#1541) Co-authored-by: Wen Zhou <[email protected]> (cherry picked from commit d538956) * Improve Kserve's FeatureTraker handing (#1562) * Improve Kserve's FeatureTraker handing - Make it possible to set FT's OwnerReference as Controller reference so the kubernetes garbage collector can block owner deletion till the FT has been deleted - Make it possible to set FT's generated resources OwnerReference as Controller reference so the kubernetes garbage collector can block FT deletion till the resources have been deleted - Add an Kserver reconciler action to remove legacy ownership on DSCI/DSC is any and related e2e tests * Update RBACs * Update RBACs * Fix findings * Update pkg/cluster/meta.go Co-authored-by: Gerard Ryan <[email protected]> * Fix renaming * Remove unrelated methods --------- Co-authored-by: Gerard Ryan <[email protected]> (cherry picked from commit bd00c9b) --------- Co-authored-by: Luca Burgazzoli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria