-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Feast Operator component #1498
base: main
Are you sure you want to change the base?
feat: Add Feast Operator component #1498
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1498 +/- ##
==========================================
- Coverage 19.84% 19.60% -0.24%
==========================================
Files 159 163 +4
Lines 10794 10926 +132
==========================================
Hits 2142 2142
- Misses 8424 8556 +132
Partials 228 228 ☔ View full report in Codecov by Sentry. |
/test all |
get_all_manifests.sh
Outdated
@@ -20,6 +20,8 @@ declare -A COMPONENT_MANIFESTS=( | |||
["trainingoperator"]="opendatahub-io:training-operator:dev:manifests" | |||
["datasciencepipelines"]="opendatahub-io:data-science-pipelines-operator:main:config" | |||
["modelcontroller"]="opendatahub-io:odh-model-controller:incubating:config" | |||
["feastoperator"]="opendatahub-io:feast:master:infra/feast-operator/config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
["feastoperator"]="opendatahub-io:feast:master:infra/feast-operator/config" | |
["feastoperator"]="opendatahub-io:feast:v0.42.0:infra/feast-operator/config" |
can we try pointing to a versioned tag instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'll still want to wait for the next release, v0.43.0, before merging this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here, we try using a floating branch so we get new code all the time, only switch to a tag from component when release odh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zdtsw its critical we lock feast into a release given that the operator CRD, reconciliation code, rbac perms, etc must be in sync with a given FEAST release. its worth noting, this is no different than what is already being done with kserve, kubeflow, & modelmesh... among others.
opendatahub-operator/get_all_manifests.sh
Lines 13 to 14 in 68c6cae
["modelmeshserving"]="opendatahub-io:modelmesh-serving:release-0.12.0-rc0:config" | |
["kserve"]="opendatahub-io:kserve:release-v0.14:config" |
opendatahub-operator/get_all_manifests.sh
Lines 10 to 11 in 68c6cae
["workbenches/kf-notebook-controller"]="opendatahub-io:kubeflow:v1.7-branch:components/notebook-controller/config" | |
["workbenches/odh-notebook-controller"]="opendatahub-io:kubeflow:v1.7-branch:components/odh-notebook-controller/config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have created the stable
branch and updated accordingly.
9e2280a
to
d1251e2
Compare
d1251e2
to
cb9f77f
Compare
cb9f77f
to
7dfbb31
Compare
7dfbb31
to
0ddcf21
Compare
Signed-off-by: Abdul Hameed <[email protected]>
0ddcf21
to
e2ddf09
Compare
@ykaliuta / @zdtsw / @MarianMacik / @ykaliuta Could you please review this PR when you get chance, or can ask if it needs to be reviewed by any other folks. thanks! |
Description
Adding Feast Operator component for Feast Feasture Store -> https://github.com/opendatahub-io/feast/tree/stable/infra/feast-operator
Jira : https://issues.redhat.com/browse/RHOAIENG-14792
How Has This Been Tested?
added Feast component as a Managed in dsc CR
status reflect with Ready
Operator logs
Feast installation successful as shown in below screen
Screenshot or short clip
Merge criteria