Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Feast Operator component #1498

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

redhatHameed
Copy link

@redhatHameed redhatHameed commented Jan 14, 2025

Description

Adding Feast Operator component for Feast Feasture Store -> https://github.com/opendatahub-io/feast/tree/stable/infra/feast-operator

Jira : https://issues.redhat.com/browse/RHOAIENG-14792

How Has This Been Tested?

added Feast component as a Managed in dsc CR

    feastoperator:
      managementState: Managed

status reflect with Ready

    - lastHeartbeatTime: '2025-01-14T15:08:15Z'
      lastTransitionTime: '2025-01-13T19:30:59Z'
      message: 1/1 deployments ready
      reason: Ready
      status: 'True'
      type: FeastOperatorReady

Operator logs

{"level":"info","ts":"2025-01-13T19:27:22Z","msg":"Starting Controller","controller":"feastoperator","controllerGroup":"components.platform.opendatahub.io","controllerKind":"FeastOperator"}


{"level":"info","ts":"2025-01-13T19:27:24Z","msg":"Starting workers","controller":"feastoperator","controllerGroup":"components.platform.opendatahub.io","controllerKind":"FeastOperator","worker count":1}


"level":"info","ts":"2025-01-13T19:30:33Z","msg":"reconcile","controller":"feastoperator","controllerGroup":"components.platform.opendatahub.io","controllerKind":"FeastOperator","FeastOperator":{"name":"default-feastoperator"},"namespace":"","name":"default-feastoperator","reconcileID":"6c5846b7-14d6-4a81-a1d8-ea324736aefb"}
{"level":"info","ts":"2025-01-13T19:30:33Z","msg":"apply","controller":"feastoperator","controllerGroup":"components.platform.opendatahub.io","controllerKind":"FeastOperator","FeastOperator":{"name":"default-feastoperator"},"namespace":"","name":"default-feastoperator","reconcileID":"6c5846b7-14d6-4a81-a1d8-ea324736aefb"}
{"level":"info","ts":"2025-01-13T19:30:33Z","msg":"Executing action","controller":"feastoperator","controllerGroup":"components.platform.opendatahub.io","controllerKind":"FeastOperator","FeastOperator":{"name":"default-feastoperator"},"namespace":"","name":"default-feastoperator","reconcileID":"6c5846b7-14d6-4a81-a1d8-ea324736aefb","action":"github.com/opendatahub-io/opendatahub-operator/v2/controllers/components/feastoperator.initialize"}
{"level":"info","ts":"2025-01-13T19:30:33Z","msg":"Executing action","controller":"feastoperator","controllerGroup":"components.platform.opendatahub.io","controllerKind":"FeastOperator","FeastOperator":{"name":"default-feastoperator"},"namespace":"","name":"default-feastoperator","reconcileID":"6c5846b7-14d6-4a81-a1d8-ea324736aefb","action":"github.com/opendatahub-io/opendatahub-operator/v2/controllers/components/feastoperator.devFlags"}
{"level":"info","ts":"2025-01-13T19:30:33Z","msg":"Executing action","controller":"feastoperator","controllerGroup":"components.platform.opendatahub.io","controllerKind":"FeastOperator","FeastOperator":{"name":"default-feastoperator"},"namespace":"","name":"default-feastoperator","reconcileID":"6c5846b7-14d6-4a81-a1d8-ea324736aefb","action":"github.com/opendatahub-io/opendatahub-operator/v2/pkg/controller/actions/render/kustomize.(*Action).run-fm"}





Feast installation successful as shown in below screen

Screenshot or short clip

Screenshot 2025-01-14 at 10 16 28 AM

Merge criteria

  • You have read the contributors guide.
  • [x ] Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • [ x] Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • [ x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [ x] The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Jan 14, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vaishnavihire for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 132 lines in your changes missing coverage. Please review.

Project coverage is 19.60%. Comparing base (eb42450) to head (e2ddf09).

Files with missing lines Patch % Lines
...trollers/components/feastoperator/feastoperator.go 0.00% 65 Missing ⚠️
...mponents/feastoperator/feastoperator_controller.go 0.00% 35 Missing ⚠️
.../feastoperator/feastoperator_controller_actions.go 0.00% 22 Missing ⚠️
.../components/feastoperator/feastoperator_support.go 0.00% 6 Missing ⚠️
pkg/upgrade/upgrade.go 0.00% 3 Missing ⚠️
...atasciencecluster/datasciencecluster_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1498      +/-   ##
==========================================
- Coverage   19.84%   19.60%   -0.24%     
==========================================
  Files         159      163       +4     
  Lines       10794    10926     +132     
==========================================
  Hits         2142     2142              
- Misses       8424     8556     +132     
  Partials      228      228              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@redhatHameed
Copy link
Author

/test all

@@ -20,6 +20,8 @@ declare -A COMPONENT_MANIFESTS=(
["trainingoperator"]="opendatahub-io:training-operator:dev:manifests"
["datasciencepipelines"]="opendatahub-io:data-science-pipelines-operator:main:config"
["modelcontroller"]="opendatahub-io:odh-model-controller:incubating:config"
["feastoperator"]="opendatahub-io:feast:master:infra/feast-operator/config"
Copy link

@tchughesiv tchughesiv Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
["feastoperator"]="opendatahub-io:feast:master:infra/feast-operator/config"
["feastoperator"]="opendatahub-io:feast:v0.42.0:infra/feast-operator/config"

can we try pointing to a versioned tag instead?

Copy link

@tchughesiv tchughesiv Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll still want to wait for the next release, v0.43.0, before merging this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here, we try using a floating branch so we get new code all the time, only switch to a tag from component when release odh.

Copy link

@tchughesiv tchughesiv Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zdtsw its critical we lock feast into a release given that the operator CRD, reconciliation code, rbac perms, etc must be in sync with a given FEAST release. its worth noting, this is no different than what is already being done with kserve, kubeflow, & modelmesh... among others.

["modelmeshserving"]="opendatahub-io:modelmesh-serving:release-0.12.0-rc0:config"
["kserve"]="opendatahub-io:kserve:release-v0.14:config"

["workbenches/kf-notebook-controller"]="opendatahub-io:kubeflow:v1.7-branch:components/notebook-controller/config"
["workbenches/odh-notebook-controller"]="opendatahub-io:kubeflow:v1.7-branch:components/odh-notebook-controller/config"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have created the stable branch and updated accordingly.

get_all_manifests.sh Outdated Show resolved Hide resolved
@redhatHameed redhatHameed force-pushed the featurestore-incubation branch from 7dfbb31 to 0ddcf21 Compare January 24, 2025 19:02
@redhatHameed redhatHameed marked this pull request as ready for review January 24, 2025 19:02
@openshift-ci openshift-ci bot requested a review from Sara4994 January 24, 2025 19:02
@redhatHameed redhatHameed force-pushed the featurestore-incubation branch from 0ddcf21 to e2ddf09 Compare January 24, 2025 19:15
@redhatHameed
Copy link
Author

@ykaliuta / @zdtsw / @MarianMacik / @ykaliuta Could you please review this PR when you get chance, or can ask if it needs to be reviewed by any other folks. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants