Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Mapping component versions to RHOAI releases #1486

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sara4994
Copy link
Contributor

@Sara4994 Sara4994 commented Jan 9, 2025

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Jan 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sara4994. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

github-actions bot commented Jan 9, 2025

This PR can't be merged just yet 😢

Please run make generate manifests api-docs and commit the changes.

For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12690455726

@biswassri
Copy link
Contributor

@Sara4994 hey just wanted to mention there is another open PR #1299 with the same title. So maybe we can add to that or close that? (Preferably add to it since we there have been previous discussions there)

@Sara4994
Copy link
Contributor Author

Sara4994 commented Jan 9, 2025

@Sara4994 hey just wanted to mention there is another open PR #1299 with the same title. So maybe we can add to that or close that? (Preferably add to it since we there have been previous discussions there)

Hey @biswassri just closed the old one. thanks

Copy link
Contributor

github-actions bot commented Jan 9, 2025

This PR can't be merged just yet 😢

Please run make generate manifests api-docs and commit the changes.

For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12695249399

@Sara4994 Sara4994 force-pushed the component-mapping-refactor branch from a2631f5 to d12ff5a Compare January 9, 2025 17:27
@ugiordan
Copy link
Contributor

/test opendatahub-operator-e2e

Copy link

openshift-ci bot commented Jan 17, 2025

@Sara4994: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/opendatahub-operator-e2e d12ff5a link true /test opendatahub-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

MarianMacik pushed a commit to MarianMacik/opendatahub-operator that referenced this pull request Jan 22, 2025
…flux/component-updates/odh-mm-rest-proxy-v2-17

chore(deps): update odh-mm-rest-proxy-v2-17 to 40e03e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants