-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Kserve defaultDeploymentMode value in DSC visible by default. #1455
Make Kserve defaultDeploymentMode value in DSC visible by default. #1455
Conversation
Signed-off-by: Vedant Mahabaleshwarkar <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR can't be merged just yet 😢Please run For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12346995309 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1455 +/- ##
=======================================
Coverage ? 19.15%
=======================================
Files ? 157
Lines ? 10337
Branches ? 0
=======================================
Hits ? 1980
Misses ? 8133
Partials ? 224 ☔ View full report in Codecov by Sentry. |
@VedantMahabaleshwarkar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@VedantMahabaleshwarkar do we still need this one? i think the latest code should have covered this case |
…flux/component-updates/odh-dashboard-v2-17 chore(deps): update odh-dashboard-v2-17 to 04c4558
Description
https://issues.redhat.com/browse/RHOAIENG-16240
Making the defaultDeploymentMode value visible by default.
How Has This Been Tested?
Screenshot or short clip
Merge criteria