-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge 'f/byon' to incubation #1629
Conversation
Refactor BYON images table
Elyra Pipelines Lack Proper Task Names
Revert adding CRD to main
Signed-off-by: Harshad Reddy Nalla <[email protected]>
Add volume to change shared memory limit on notebook
…components, manifest list digest of v4.10 as of July 8 or so
…andard_v410_based_digest standard ose-oauth-proxy image in digest format as used in all other …
fix jump links scroll behavior
Uploading a malformed pipeline yaml results in a blank page
Update modals and generate meaningful k8s name for images
Fix docs and community link
Gracefully handle image packages and software JSON parse error
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@DaoDaoNoCode: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Checked the items in the checklist. All looks good.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: manaswinidas The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Add custom notebook phase 1 work to incubation branch
How Has This Been Tested?
Image locations you could use to test:
Test instructions:
Import notebook image
, and try to create an image using the locations aboveEnter
could help you to save the row and move to the next row. If you are current on the last row, it will create a new row. HitEsc
could exit the edit mode and abandon the current change on the row.Test checklist:
Enable
toggle locked and disabledTest Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main