RHOAIENG-15152: test(tests/browser): add playwright test for starting code-server #774
Conversation
jiridanek
added
the
tide/merge-method-squash
jiridanek
added
the
trivy-scan
This reverts commit 629e732.
jiridanek
changed the title
|
/override ci/prow/images |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I don't say I understand this fully, but LGTM in general. Thank you! /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jiridanek: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/override ci/prow/codeserver-notebook-e2e-tests |
|
@jiridanek: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/images |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
… code-server (opendatahub-io#774) * RHOAIENG-15152: feat(codeserver/e2e): add playwright test for starting code-server * DO-NOT-COMMIT: trigger GHA * fixup typo in utils.ts * fixup default to not using existing CDP browser instance * fixup remove commented code about using dotenv * fixup print more meaningful exception when misconfigured * fixup forgot to change paths in gha * suppress the npm funding message * Revert "DO-NOT-COMMIT: trigger GHA" This reverts commit 629e732. (cherry picked from commit cd16a28)
… code-server (opendatahub-io#774) * RHOAIENG-15152: feat(codeserver/e2e): add playwright test for starting code-server * DO-NOT-COMMIT: trigger GHA * fixup typo in utils.ts * fixup default to not using existing CDP browser instance * fixup remove commented code about using dotenv * fixup print more meaningful exception when misconfigured * fixup forgot to change paths in gha * suppress the npm funding message * Revert "DO-NOT-COMMIT: trigger GHA" This reverts commit 629e732. (cherry picked from commit cd16a28)
https://issues.redhat.com/browse/RHOAIENG-15152
Description
Followup to
How Has This Been Tested?
Played with it on my machine, and let the GHA run, see the attached test report Artifacts at
(before I reverted the whitespace change I used to force image rebuild and retest).
Merge criteria: