-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-2003: feat(metadata/codeserver): update VSCode imagestream annotations with installed software #756
RHOAIENG-2003: feat(metadata/codeserver): update VSCode imagestream annotations with installed software #756
Conversation
3c1404d
to
67ccd8f
Compare
566b923
to
dff303d
Compare
@jiridanek thank you for this and thank you for enhancing/fixing the CI for this change. In general this LGTM and I put just one comment regarding the addition of the UBI information here. I don't insist on the removal but I think we should consider it. |
…nnotations with installed software
…separate file, in case json strings are multiline
dff303d
to
01f4e64
Compare
Great representation by using the |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/images rocm failed to build |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
absolutely, filled task https://issues.redhat.com/browse/RHOAIENG-15242 |
https://issues.redhat.com/browse/RHOAIENG-2003
Description
Took into account the good suggestions from https://issues.redhat.com/browse/RHOAIRFE-320 as well.
I've also added the
# language=json
injection comment described at https://www.jetbrains.com/help/idea/using-language-injections.html#use-language-injection-comments. If there's something similar for people using different IDEs, we can change it for something more portable later.Finally, I put some newlines into the annotation, to make it easier for people to read it.
How Has This Been Tested?
I'm going to run Kustomize, copy out the rendered manifest, rename it, and put it into my cluster. Then I'll check in the dashboard how it renders.
Merge criteria: