RHOAIENG-14518: feat(codeserver): disable the VSCode workspace trust mechanism and the trust prompt #754
Conversation
…mechanism and the trust prompt
ocp-ci pr build broken again |
|
Tested locally |
|
I also did run with podman, like @atheo89 did and no more popups, looks great! $ podman run -it --rm -p 8787:8787 quay.io/opendatahub/workbench-images:codeserver-ubi9-python-3.11-pr-754/lgtm |
|
/approve thanks for the review! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/images timeouts on rocm images, known ci issue |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
/test codeserver-notebook-e2e-tests
There was a problem hiding this comment.
/override ci/prow/codeserver-notebook-e2e-tests
|
too late, but yeah /lgtm |
|
cI failed on Build image rocm-ubi9-python-3.11 from the repository, let's override |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/codeserver-notebook-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 6434946
into
opendatahub-io:main
https://issues.redhat.com/browse/RHOAIENG-14518
Description
Trust the authors popup appears the first time user opens code-server (VSCode) workbench. It is super scary and confuses users. What is this folder /opt/app-root/src? Is a security risk for my company if I authorize this?
We are taking the decision to spare our users such considerations by removing the VSCode workspace trust completely. Therefore the workspace will be automatically trusted and user will not be prompted about no trust whatsoever.
Alternatively, same thing could've been implemented by running
code-server --disable-workspace-trustinstead of modifying settings.I looked into the Workspace Trust Editor, https://github.com/microsoft/vscode/blob/56b535f40900080fac8202c77914c5ce49fa4aae/src/vs/workbench/contrib/workspace/browser/workspaceTrustEditor.ts, trying to find where it stores trusted paths, since then maybe we could preconfigure /opt/app-root/src to be already trusted, but I did not find this.
How Has This Been Tested?
I've loaded images into rhoai 2.13, checked that I don't see scary modal anymore at startup, and checked settings to see that they look like what I expected.
Merge criteria: