RHOAIENG-14520: fix(vscode): change supervisord files location #747
Conversation
|
/retitle RHOAIENG-14520: fix(vscode): change supervisord files location |
openshift-ci
bot
changed the title
|
/lgtm can you eventually rebase the PR on main, to get a recent-ish fix for gha? |
|
/lgtm |
|
Thank you @guimou for this fix! Looks much better now 🙂 /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
/retest-required |
1 similar comment
|
/retest-required |
|
We're ready to have this for 2.16. The tests will fail anyways, so there's still lots of time to object if anyone objects ;P /unhold |
|
/test codeserver-notebook-e2e-tests |
|
The test issues are because we aren't able to reliably build our images on ocp-ci for a pr. There's no way all of rocm will get built at the same time even if I retrigger few more times, so let's override the way we always do /override ci/prow/images |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/codeserver-notebook-e2e-tests, ci/prow/images, ci/prow/rstudio-notebook-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest "pytest-tests (pull_request)" |
|
@jiridanek: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "pytest-tests (pull_request)" |
|
@jiridanek: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pytest-tests |
|
@jiridanek: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override pytest-tests |
|
@jiridanek: Overrode contexts on behalf of jiridanek: pytest-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 1595213
into
opendatahub-io:main
The current supervisord configuration creates two file in /opt/app-root/src:
This can be confusing for users, who don't know where they come from, what they do, if they can/should delete them... Especially as even if they are deleted they will keep coming back.
This PR modifies supervisord configuration to put those files under /tmp. That way they are hidden to the user, and reinitialized at each restart of the workbench (instead of having the log file growing).