Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] manifest for TensorFlow image to show proper Numpy package version #743

Merged

Conversation

jstourac
Copy link
Member

This partially reverts the #742 to fix the expected version in the final image.

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

This partially reverts the opendatahub-io#742 to fix the
expected version in the final image.
@jiridanek
Copy link
Member

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstourac
Copy link
Member Author

/approved
/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images

In response to this:

/approved
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jstourac
Copy link
Member Author

/override pytest-tests

Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

@jstourac: Overrode contexts on behalf of jstourac: pytest-tests

In response to this:

/override pytest-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 596ca14 into opendatahub-io:main Oct 14, 2024
7 of 8 checks passed
@jstourac jstourac deleted the fixVersionNumpyTensorflow branch October 14, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants