Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Digest Updater Action] Update Notebook Images #736

Merged
merged 5 commits into from
Oct 5, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 5, 2024

🚀 This is an automated Pull Request.
Created by /.github/workflows/notebooks-digest-updater-upstream.yaml

This PR updates the following files:

  • manifests/base/params.env file with the latest updated SHA digests of the notebooks (N & N-1).
  • manifests/base/commit.env file with the latest commit (N & N-1).

IMPORTANT NOTE: Remember to delete the digest-updater-11191131900 branch after merging the changes

Copy link
Contributor

openshift-ci bot commented Oct 5, 2024

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@harshad16
Copy link
Member

/ok-to-test

@harshad16
Copy link
Member

/lgtm
/approve
/ok-to-test

The validation is failing as it points to the wrong values.
a follow up pr would be created to fix it.

Copy link
Contributor

openshift-ci bot commented Oct 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed lgtm labels Oct 5, 2024
@openshift-ci openshift-ci bot added the approved label Oct 5, 2024
@harshad16 harshad16 merged commit 13dbeb3 into main Oct 5, 2024
68 of 72 checks passed
@harshad16 harshad16 deleted the digest-updater-11191131900 branch October 5, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ok-to-test tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant