Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing deps to Pipfile and fix a typo #93

Merged
merged 2 commits into from
Oct 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .github/workflows/pre_commit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,23 +20,28 @@ jobs:
uses: actions/setup-python@v5
with:
python-version: "3.12"
cache: pipenv

- name: Setup Pipenv
uses: tiagovrtr/actions-pipenv@v1
with:
pipenv-version: "v2024.1.0"

- name: Configure caching
uses: actions/cache@v4
with:
path: ~/.cache/pre-commit
key: precommit-${{ runner.os }}-${{ hashFiles('.pre-commit-config.yaml') }}

- name: Install pre-commit
- name: Install dependencies
run: |
pip install pre-commit
pipenv sync

- name: Run pre-commit
run: |
pre-commit run --all-files
pipenv run pre-commit run --all-files

- name: Test if pipeline is up-to-date
run: |
pip install click kfp==2.9.0 kfp.kubernetes
make pipeline
pipenv run make pipeline
git diff --exit-code || (echo "Pipeline is not up-to-date. Please run 'make pipeline' and commit the changes." && exit 1)
6 changes: 5 additions & 1 deletion Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,12 @@ name = "pypi"
[packages]
kfp = {extras = ["kubernetes"], version = "*"}
click = "*"
ruff = "*"
pyyaml = "*"
kubernetes = "*"
pre-commit = "*"

[dev-packages]

[requires]
python_version = "3.11"
python_version = "3.12"
Loading