Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulk: tar improvements and upload final model #90

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

leseb
Copy link
Collaborator

@leseb leseb commented Oct 11, 2024

13a8c56 bulk: tar improvements and upload final model

commit 13a8c56
Author: Sébastien Han [email protected]
Date: Fri Oct 11 16:38:23 2024 +0200

bulk: tar improvements and upload final model

* the tar scan was running very slowly and was taken almost (if not
  longer) than extracting the content, so we removed it.
* After extraction, we check for mandatory dirs to be present
* Implement the new `upload-trained-model` subcommand to push the
  trained model back to S3. UNTESTED

Signed-off-by: Sébastien Han <[email protected]>

@leseb leseb force-pushed the s3-push-back-tar branch 3 times, most recently from e8aa367 to 8165f25 Compare October 11, 2024 15:08
* the tar scan was running very slowly and was taken almost (if not
  longer) than extracting the content, so we removed it.
* After extraction, we check for mandatory dirs to be present
* Implement the new `upload-trained-model` subcommand to push the
  trained model back to S3. UNTESTED

Signed-off-by: Sébastien Han <[email protected]>
Copy link
Collaborator

@MichaelClifford MichaelClifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MichaelClifford MichaelClifford merged commit b3ff1dc into opendatahub-io:main Oct 11, 2024
1 check passed
@leseb leseb deleted the s3-push-back-tar branch October 14, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants