Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytorch env var #89

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

sallyom
Copy link
Collaborator

@sallyom sallyom commented Oct 11, 2024

A few things I noticed when running the standalone script

/cc @MichaelClifford @leseb

Copy link
Collaborator

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about the tar inspect

standalone/standalone.py Outdated Show resolved Hide resolved
@sallyom sallyom force-pushed the remove-pytorch-env-var branch from 1c33301 to fb232b4 Compare October 11, 2024 14:04
@sallyom sallyom changed the title Remove pytorch env var & update tar inspect Remove pytorch env var Oct 11, 2024
Copy link
Collaborator

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to edit standalone.tpl then run make standalone. Thanks

@sallyom sallyom force-pushed the remove-pytorch-env-var branch from fb232b4 to 8bb8976 Compare October 11, 2024 14:13
@sallyom
Copy link
Collaborator Author

sallyom commented Oct 11, 2024

I don't see anything to update in standalone.tpl, I removed the tar update commit - ready for review

@leseb
Copy link
Collaborator

leseb commented Oct 14, 2024

I don't see anything to update in standalone.tpl, I removed the tar update commit - ready for review

My bad this part comes from a component. All good!

@leseb leseb merged commit 96b1c1e into opendatahub-io:main Oct 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants