Add dockerfile for Python Runtime Image & parameterize images in makefile via env #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Humair Khan <[email protected]>
Signed-off-by: Humair Khan <[email protected]>
This change also includes an addition of a requirements.txt for installing the packages during image build, this allows us to avoid including uv as a dependency in the image. Also included is a dockerignore file, ci, and readme changes to accomodate the change. Signed-off-by: Humair Khan <[email protected]>
mprahl
approved these changes
Jan 27, 2025
HumairAK
changed the title
|
fyi @MichaelClifford / @leseb / @tumido / @Shreyanand / et al |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change does the following:
The following change will allow us to build the pipeline during a runtime init container step, that will allow us to consume updated images in an automated way in the future.
Image defaults in makefile are kept as SHA for now, once automation is enabled, we should set these to floating tags.
Instead of adding
requirements.txtanother option is to just leverageuv, this would require us to include this as an additional package dependency in the image, and I think do auv pip install --system, I'm not that familiar with uv however.Jira: https://issues.redhat.com/browse/RHOAIENG-18413
How Has This Been Tested?
Ran the pipeline with the built image set to PYTHON Image.
Merge criteria: