-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ILAB Phase 3 Github Markdown Documentation #254
base: main
Are you sure you want to change the base?
ILAB Phase 3 Github Markdown Documentation #254
Conversation
56a33a6
to
55716b8
Compare
@@ -0,0 +1,646 @@ | |||
# Running InstructLab Pipeline with Data Science Pipelines on RHOAI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by definition, this doc should be in a different directory than standalone
, since this is running on DSP
|
||
Upload the created tar archive to your object store. | ||
|
||
The `standalone.py` script will do a simple validation check on the directory structure, here is a sample of what |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
standalone.py no longer used in Phase 2, change this to 'The pipeline'
|`k8s_storage_class_name` |A Kubernetes StorageClass name for persistent volumes. Selected StorageClass must support RWX PersistentVolumes.| | ||
|
||
|
||
[RBAC configuration]: https://github.com/opendatahub-io/ilab-on-ocp/tree/main/standalone#rbac-requirements-when-running-in-a-kubernetes-job |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should copy this documentation somewhere not in 'standalone' folder
* Red Hat - Authorino installed | ||
* Red Hat Openshift Serverless installed | ||
* Red Hat OpenShift Service Mesh v2 (v3 is not compatible with RHOAI) | ||
* Red Hat OpenShift AI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Red Hat OpenShift AI | |
* Red Hat OpenShift AI and operator dependencies documented at [OpenShift AI Supported Configurations](https://access.redhat.com/articles/rhoai-supported-configs)) |
$ cp -r <path-to-model-downloaded-dir>/rhelai1/granite-7b-starter/* s3-data/model | ||
``` | ||
|
||
Add your taxonomy tree to the `taxonomy` directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
<p align="center"><img src="assets/images/parameters.png" width=50%\></p> | ||
|
||
#### Available Pipeline Parameters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about adding two additional sections providing example pipeline parameters?
-
Example pipeline parameters for a quick pipeline run:
Example parameters to do a quick test that can be run in aprox 90m using x NVIDIA XXX GPUs -
Example pipeline parametes for a full pipeline run
2b49ac2
to
0576ffc
Compare
run-pipeline-on-rhoai-.md
Outdated
|
||
```bash | ||
oc new-project nfs | ||
oc apply -f ./nfs-server-deployment.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The document doesn't explain where is this file downloaded or what should be the content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now that the file is in the standalone folder. Consider adding a link in the markdown doc
run-pipeline-on-rhoai-.md
Outdated
|
||
For creating NFS storage-class | ||
```bash | ||
oc apply -f ./nfs-storage-class.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The document doesn't explain where is this file downloaded or what should be the content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now that the file is in the standalone folder. Consider adding a link in the markdown doc
Signed-off-by: VaniHaripriya <[email protected]>
9dcc5b5
to
35d60f0
Compare
Description
Added instructions to run InstructLab Pipeline with Data Science Pipelines on RHOAI
How Has This Been Tested?
Merge criteria: