Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use image sha256 instead of tags #253

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

DharmitD
Copy link
Member

Description

Update images to use sha256 instead of tags, so that users can utilize them for scenarios such as disconnected cluster mirroring.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@VaniHaripriya
Copy link
Contributor

@DharmitD Please fix the pre-commit errors.

@DharmitD
Copy link
Member Author

@DharmitD Please fix the pre-commit errors.

@VaniHaripriya Done, the CI runs passed successfully.

@VaniHaripriya
Copy link
Contributor

/lgtm
Verified by executing make pipeline, which successfully generated the pipeline.yaml file.

$ make pipeline
python3 pipeline.py
/home/vmudadla/OpenshiftAI/ilab-on-ocp/training/components.py:339: SyntaxWarning: invalid escape sequence '\$'
  """
/home/vmudadla/OpenshiftAI/ilab-on-ocp/training/components.py:339: SyntaxWarning: invalid escape sequence '\$'
  """
Generating pipeline  [####################################]  100%                        
(venv) (base) [vmudadla@vmudadla-thinkpadp1gen3 ilab-on-ocp]$ git status
On branch image-shas
Your branch is up to date with 'dharmit-fork/image-shas'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   importer-pipeline.yaml
	modified:   pipeline.yaml

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	tests/dsp-ca.crt
	tests/ingress-operator.crt
	tests/server-cert.crt
	tests/server.crt

@HumairAK
Copy link
Contributor

/lgtm

@HumairAK HumairAK merged commit c923f17 into opendatahub-io:main Jan 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants