Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulk: house keeping #104

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

leseb
Copy link
Collaborator

@leseb leseb commented Oct 17, 2024

24abae6 bulk: house keeping

commit 24abae6
Author: Sébastien Han [email protected]
Date: Thu Oct 17 11:18:01 2024 +0200

bulk: house keeping

- re-arrange top-level section variables for readability
- use env in pytorchjbob instead of export
- do not hardcode things for executors coming from pipeline.py and use
  string formatting with values from standalone.py instead
- some fixes for SDG  (full SDG run not data fetch)
- catch a broader exception for watcher when connection is broken

Signed-off-by: Sébastien Han <[email protected]>

@leseb leseb force-pushed the standalone-more-alone branch from efd6b71 to bd8d1f1 Compare October 17, 2024 09:31
@leseb leseb changed the title bulkd: house keeping bulk: house keeping Oct 17, 2024
@leseb leseb force-pushed the standalone-more-alone branch 3 times, most recently from 9bbca24 to 253376a Compare October 17, 2024 10:14
@leseb
Copy link
Collaborator Author

leseb commented Oct 17, 2024

I'm still fixing the watcher exception catch, so holding this a little.

EDIT: ok now it's fixed!

@leseb leseb force-pushed the standalone-more-alone branch 3 times, most recently from 94c0cd8 to bfa3b2c Compare October 17, 2024 12:35
- re-arrange top-level section variables for readability
- use env in pytorchjbob instead of export
- do not hardcode things for executors coming from pipeline.py and use
  string formatting with values from standalone.py instead
- some fixes for SDG  (full SDG run not data fetch)
- catch a broader exception for watcher when connection is broken

Signed-off-by: Sébastien Han <[email protected]>
@leseb leseb force-pushed the standalone-more-alone branch from bfa3b2c to 24abae6 Compare October 17, 2024 15:01
Copy link
Collaborator

@MichaelClifford MichaelClifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelClifford MichaelClifford merged commit 936c9d7 into opendatahub-io:main Oct 17, 2024
1 check passed
@leseb leseb deleted the standalone-more-alone branch October 17, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants