Skip to content

Commit

Permalink
Add compile-time switches for phase skipping
Browse files Browse the repository at this point in the history
Signed-off-by: Giulio Frasca <[email protected]>
  • Loading branch information
gmfrasca committed Feb 8, 2025
1 parent 91d6fea commit ca51d77
Show file tree
Hide file tree
Showing 8 changed files with 5,195 additions and 128 deletions.
69 changes: 69 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,82 @@ TOOLBOX_IMAGE ?= "registry.redhat.io/ubi9/toolbox@sha256:da31dee8904a535d12689
OC_IMAGE ?= "registry.redhat.io/openshift4/ose-cli@sha256:08bdbfae224dd39c81689ee73c183619d6b41eba7ac04f0dce7ee79f50531d0b" # v4.15.0
RHELAI_IMAGE ?= "registry.redhat.io/rhelai1/instructlab-nvidia-rhel9@sha256:05cfba1fb13ed54b1de4d021da2a31dd78ba7d8cc48e10c7fe372815899a18ae" # v1.3.2

# Compile Params
ILAB_PIPELINE_FILE_NAME ?= "pipeline.yaml"
ILAB_SKIP_SDG ?= ""
ILAB_SKIP_TRAINING_PHASE_1 ?= ""
ILAB_SKIP_TRAINING_PHASE_2 ?= ""
ILAB_SKIP_EVAL_MTBENCH ?= ""
ILAB_SKIP_EVAL_FINAL ?= ""
ILAB_SKIP_UPLOAD_RESULT_MODEL ?= ""
ILAB_SKIP_CLEANUP_PVCS ?= ""

standalone:
python3 pipeline.py gen-standalone
ruff format standalone/standalone.py

.PHONY: pipeline_all
pipeline_all: pipeline pipeline_sdgonly pipeline_dataproconly pipeline_trainonly

pipeline:
PYTHON_IMAGE=$(PYTHON_IMAGE) \
TOOLBOX_IMAGE=$(TOOLBOX_IMAGE) \
OC_IMAGE=$(OC_IMAGE) \
RHELAI_IMAGE=$(RHELAI_IMAGE) \
python3 pipeline.py

pipeline_sdgonly:
PYTHON_IMAGE=$(PYTHON_IMAGE) \
TOOLBOX_IMAGE=$(TOOLBOX_IMAGE) \
OC_IMAGE=$(OC_IMAGE) \
RHELAI_IMAGE=$(RHELAI_IMAGE) \
ILAB_PIPELINE_FILE_NAME="pipeline_sdgonly.yaml" \
ILAB_SKIP_DATA_PROCESSING="True" \
ILAB_SKIP_TRAINING_PHASE_1="True" \
ILAB_SKIP_TRAINING_PHASE_2="True" \
ILAB_SKIP_EVAL_MTBENCH="True" \
ILAB_SKIP_EVAL_FINAL="True" \
ILAB_SKIP_UPLOAD_RESULT_MODEL="True" \
ILAB_SKIP_UPLOAD_METRICS="True" \
python3 pipeline.py

pipeline_dataproconly:
PYTHON_IMAGE=$(PYTHON_IMAGE) \
TOOLBOX_IMAGE=$(TOOLBOX_IMAGE) \
OC_IMAGE=$(OC_IMAGE) \
RHELAI_IMAGE=$(RHELAI_IMAGE) \
ILAB_PIPELINE_FILE_NAME="pipeline_dataproconly.yaml" \
ILAB_SKIP_SDG="True" \
ILAB_SKIP_TRAINING_PHASE_1="True" \
ILAB_SKIP_TRAINING_PHASE_2="True" \
ILAB_SKIP_EVAL_MTBENCH="True" \
ILAB_SKIP_EVAL_FINAL="True" \
ILAB_SKIP_UPLOAD_RESULT_MODEL="True" \
ILAB_SKIP_UPLOAD_METRICS="True" \
python3 pipeline.py

pipeline_trainonly:
PYTHON_IMAGE=$(PYTHON_IMAGE) \
TOOLBOX_IMAGE=$(TOOLBOX_IMAGE) \
OC_IMAGE=$(OC_IMAGE) \
RHELAI_IMAGE=$(RHELAI_IMAGE) \
ILAB_PIPELINE_FILE_NAME="pipeline_trainonly.yaml" \
ILAB_SKIP_SDG="True" \
ILAB_SKIP_EVAL_MTBENCH="True" \
ILAB_SKIP_EVAL_FINAL="True" \
ILAB_SKIP_UPLOAD_RESULT_MODEL="True" \
ILAB_SKIP_UPLOAD_METRICS="True" \
python3 pipeline.py

# TODO(gfrasca): ucomment once we have implemented trainingonly
# pipeline_evalonly:
# PYTHON_IMAGE=$(PYTHON_IMAGE) \
# TOOLBOX_IMAGE=$(TOOLBOX_IMAGE) \
# OC_IMAGE=$(OC_IMAGE) \
# RHELAI_IMAGE=$(RHELAI_IMAGE) \
# ILAB_PIPELINE_FILE_NAME="pipeline_evalonly.yaml" \
# ILAB_SKIP_SDG="True" \
# ILAB_SKIP_TRAINING_PHASE_1="True" \
# ILAB_SKIP_TRAINING_PHASE_2="True" \
# ILAB_SKIP_UPLOAD_RESULT_MODEL="True" \
# python3 pipeline.py
Loading

0 comments on commit ca51d77

Please sign in to comment.