Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For release 1.8.11 #1398

Merged
merged 4 commits into from
Feb 6, 2023
Merged

For release 1.8.11 #1398

merged 4 commits into from
Feb 6, 2023

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Feb 6, 2023

Reason for this pull request

Preparing for 1.8.11 release.

Proposed changes

  • Update whats_new
    -Confirm conda and pip dependencies are in sync.

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes


📚 Documentation preview 📚: https://datacube-core--1398.org.readthedocs.build/en/1398/

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 91.96% // Head: 91.96% // No change to project coverage 👍

Coverage data is based on head (277f312) compared to base (42e2726).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1398   +/-   ##
========================================
  Coverage    91.96%   91.96%           
========================================
  Files          133      133           
  Lines        14450    14450           
========================================
  Hits         13289    13289           
  Misses        1161     1161           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SpacemanPaul
Copy link
Contributor Author

I don't know why the conda smoke tests are failing - seems to be unable to install shapely>=2.0.0 But it looks like conda-forge has shapely-2.0.1:

https://anaconda.org/conda-forge/shapely

@omad
Copy link
Member

omad commented Feb 6, 2023

I don't know why the conda smoke tests are failing - seems to be unable to install shapely>=2.0.0 But it looks like conda-forge has shapely-2.0.1:

https://anaconda.org/conda-forge/shapely

I suspect the problem is this line, and that it should be removed: https://github.com/opendatacube/datacube-core/blob/develop/.github/workflows/test-conda-build.yml?plain=1#L38

See conda-incubator/setup-miniconda#267

The new conda-forge packages for shapely are only published as .conda files, not as .tar.bz2.

@SpacemanPaul
Copy link
Contributor Author

Thanks, Damien - that does seem to have done the trick and it would have taken me ages to figure that out!

@SpacemanPaul SpacemanPaul merged commit 46f769f into develop Feb 6, 2023
@SpacemanPaul SpacemanPaul deleted the for_release_1.8.11 branch February 6, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants