Update readme to use ibpc #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.0.3 is now on pip
Signed-off-by: Tully Foote <[email protected]>
vahetag
requested changes
Feb 13, 2025
README.md
Outdated
|
|
||
| ## Run the test | ||
|
|
||
| **At the moment the published tester is not available. You will have to build it locally see below in Development to build `ibpc:tester` and pass --tester-image `ibpc:tester` |
Collaborator
There was a problem hiding this comment.
@tfoote Shouldn't there be docker builds first?
Collaborator
There was a problem hiding this comment.
Also worth adding a note that people need to rebuild the docker image every time they change their pose_estimator code
Collaborator
Author
There was a problem hiding this comment.
As soon as the packages are made public they won't have to build anything.
README.md
Outdated
| **At the moment the published tester is not available. You will have to build it locally see below in Development to build `ibpc:tester` and pass --tester-image `ibpc:tester` | ||
|
|
||
| ``` | ||
| bpc test ipd |
Collaborator
There was a problem hiding this comment.
@tfoote This command is wrong, right? people also need to pass the ibpc:pose_estimator
Collaborator
Author
There was a problem hiding this comment.
Yeah, that's missing here, added
tfoote
commented
Feb 13, 2025
Collaborator
Author
tfoote
left a comment
tfoote
left a comment
There was a problem hiding this comment.
I've added some more details.
README.md
Outdated
| **At the moment the published tester is not available. You will have to build it locally see below in Development to build `ibpc:tester` and pass --tester-image `ibpc:tester` | ||
|
|
||
| ``` | ||
| bpc test ipd |
Collaborator
Author
There was a problem hiding this comment.
Yeah, that's missing here, added
README.md
Outdated
|
|
||
| ## Run the test | ||
|
|
||
| **At the moment the published tester is not available. You will have to build it locally see below in Development to build `ibpc:tester` and pass --tester-image `ibpc:tester` |
Collaborator
Author
There was a problem hiding this comment.
As soon as the packages are made public they won't have to build anything.
AllProAi
pushed a commit
to AllProAi/bpc
that referenced
this pull request
Mar 17, 2025
* Update readme to use ibpc 0.0.3 is now on pip * Clean up ibpc_py README.md Signed-off-by: Tully Foote <[email protected]> * add forward references to the build instructions * restructure for clarity * tip about cuda * typos from internal review * fix list --------- Signed-off-by: Tully Foote <[email protected]>
ramamoorthyluxman
pushed a commit
to ramamoorthyluxman/bpc
that referenced
this pull request
Aug 5, 2025
* Update readme to use ibpc 0.0.3 is now on pip * Clean up ibpc_py README.md Signed-off-by: Tully Foote <[email protected]> * add forward references to the build instructions * restructure for clarity * tip about cuda * typos from internal review * fix list --------- Signed-off-by: Tully Foote <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.0.3 is now on pip
I successfully ran it on my machine with the default implementation.
I'd love to see this extended with how to run baseline on a published image before merge.