Save results to csv file #33
Conversation
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
| # result stage: base + copied install folders from the overlay + service setup. | ||
| FROM base | ||
|
|
||
| ARG DATASET_NAME |
There was a problem hiding this comment.
Can this be set to default as "ipd"?
| ARG DATASET_NAME | |
| ARG DATASET_NAME=ipd |
There was a problem hiding this comment.
Embedding these into the image is causing a challenge as it gets baked into the command as well. In working on the automation I have been manually overriding the DATASET_NAME and building the image locally to get it working quickly instead of trying to override the full CMD. I think that the CMD is getting baked with the build ENV, not the runtime ENV.
tfoote
left a comment
tfoote
left a comment
There was a problem hiding this comment.
I've said this before I'd really like to get any of the runtime settings out of the image so that they're reusable and we don't have to rebuild them to change what dataset we're running against. Lets follow up on that separately though..
I added a commit extending bpc command line tool to support mounting it through.
| # result stage: base + copied install folders from the overlay + service setup. | ||
| FROM base | ||
|
|
||
| ARG DATASET_NAME |
There was a problem hiding this comment.
Embedding these into the image is causing a challenge as it gets baked into the command as well. In working on the automation I have been manually overriding the DATASET_NAME and building the image locally to get it working quickly instead of trying to override the full CMD. I think that the CMD is getting baked with the build ENV, not the runtime ENV.
| test_parser.add_argument("estimator_image") | ||
| test_parser.add_argument("dataset") | ||
| test_parser.add_argument("--dataset_directory", action="store", default=".") | ||
| test_parser.add_argument("--result_directory", action="store", default=".") |
There was a problem hiding this comment.
bpc will now offer to set this and automatically mount it through for you.
Sounds good. |
Also a little bit of cleanup of command line parsing. Signed-off-by: Tully Foote <[email protected]>
tfoote
force-pushed
the
vt/tester_update
branch
from
1f7a225 to
68b9fc7
Compare
Signed-off-by: Yadunund <[email protected]>
|
Can you guys also update either the build or run command for the tester container to pass the |
|
yeah, I have defaulted it as well in #35 for now. |
|
I'm going to merge this as the build is broken without it. e.g #36 |
This PR updates the
testerto compile results into a csv file in a format similar to what was expected in previous bop challenges. The only difference being instead of separating matrix elements by spaces, we use commas.This file is further written to disk to directory / filename that can be configured. By default it writes to
/submission/submission.cvs. README is updated to mount another volume for this output directory so that the results can be accessed outside of the container.Lastly, I took the liberty to bump the zenoh router to
1.2.1.to match the zenoh version in the latest jazzy binaries that were released today