Cleaning up #303
Merged
Cleaning up #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… peer dependencies. They were originally here so that we could easily find out when a new version of them is available (since we "manually" import them), but it's not good to have things under `peerDependencies` unless actually needed. So, removing them... which means that we will need to "manually" check whether a new version of `mathjs` and/or `plotly.js-gl2d-dist-min` is available.
… the toolbar. The objective is for the center template to always in the same place.
…igonometric operators.
There was a problem hiding this comment.
Pull request overview
This pull request performs code cleanup and maintenance tasks including API improvements, UI refinements, dependency updates, and configuration enhancements.
Key changes include:
- Making the
idfield required in UI JSON input interfaces to improve type safety - Refactoring code to extract reusable parameter population logic
- Updating developer dependencies (@biomejs/biome, vite) to newer versions
- Enhancing Biome configuration with VCS integration
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/src/libopencor/locUiJsonApi.ts | Changed id from optional to required in input interfaces and updated validation schema |
| src/renderer/src/components/views/SimulationExperimentView.vue | Extracted parameter population logic into reusable function, updated UI controls, removed obsolete id checks, added mathjs function imports |
| src/renderer/src/components/views/IssuesView.vue | Made width/height props optional with defaults, improved responsive sizing logic |
| src/renderer/src/components/dialogs/AboutDialog.vue | Migrated from inline style to Tailwind utility class |
| src/renderer/src/components/BackgroundComponent.vue | Standardized border-radius using Tailwind utility class |
| src/renderer/package.json | Updated version to 0.20251203.0, removed mathjs and plotly from peerDependencies (CDN imports), updated @biomejs/biome and vite |
| src/renderer/bun.lock | Updated lock file entries for @biomejs/biome and vite, removed unused mathjs dependencies |
| src/renderer/biome.json | Simplified includes pattern, added VCS git integration configuration |
| package.json | Updated version to 0.20251203.0, removed mathjs and plotly from peerDependencies, updated @biomejs/biome and vite |
| bun.lock | Updated lock file entries for @biomejs/biome and vite, removed unused mathjs dependencies |
| biome.json | Simplified includes pattern, added VCS git integration configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.