libct/int: retry Checkpoint for cgroup v1 #4486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
force-pushed
the
retry-freeze
branch
from
a05e50d to
758bb6c
Compare
|
@opencontainers/runc-maintainers PTAL |
Cgroup v1 freezer have issues when trying to freeze a cgroup, and despite criu retries, it may fail like this: === RUN TestCheckpoint time="2024-10-18T08:55:44Z" level=warning msg="--- Quoting "/tmp/TestCheckpoint214687474/003/criu-parent/dump.log"" time="2024-10-18T08:55:44Z" level=warning msg="118:(09.517977) freezer.state=FREEZING" time="2024-10-18T08:55:44Z" level=warning msg="119:(09.618087) freezer.state=FREEZING" time="2024-10-18T08:55:44Z" level=warning msg="120:(09.718192) freezer.state=FREEZING" time="2024-10-18T08:55:44Z" level=warning msg="121:(09.818291) freezer.state=FREEZING" time="2024-10-18T08:55:44Z" level=warning msg="122:(09.918412) freezer.state=FREEZING" time="2024-10-18T08:55:44Z" level=warning msg="123:(10.001045) Error (criu/cr-dump.c:1779): Timeout reached. Try to interrupt: 0" time="2024-10-18T08:55:44Z" level=warning msg="124:(10.001084) freezer.state=FREEZING" time="2024-10-18T08:55:44Z" level=warning msg="125:(10.001125) Unfreezing tasks into 1" time="2024-10-18T08:55:44Z" level=warning msg="126:(10.001128) \tUnseizing 45035 into 1" time="2024-10-18T08:55:44Z" level=warning msg="127:(10.001140) Error (compel/src/lib/infect.c:418): Unable to detach from 45035: No such process" time="2024-10-18T08:55:44Z" level=warning msg="128:(10.001144) Writing image inventory (version 1)" time="2024-10-18T08:55:44Z" level=warning msg="129:(10.001223) Error (criu/cr-dump.c:1893): Pre-dumping FAILED." time="2024-10-18T08:55:44Z" level=warning msg=--- checkpoint_test.go:93: criu failed: type PRE_DUMP errno 0 Since cgroup v1 is going to be deprecated, and the problem doesn't exist on cgroup v2, let's retry the checkpoint a few times (on v1 only) to avoid flaky tests. Issues 4457, 4273. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
retry-freeze
branch
from
758bb6c to
f7a9623
Compare
|
I am hesitant into moving this logic into This is why we only patch tests here (to have less flakes). |
lifubang
approved these changes
Dec 13, 2024
|
Let's have it in CRIU instead: checkpoint-restore/criu#2545 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cgroup v1 freezer have issues when trying to freeze a cgroup, and despite criu retries, it may fail like this:
Since cgroup v1 is going to be deprecated, and the problem doesn't exist on cgroup v2, let's retry the checkpoint a few times (on v1 only) to avoid flaky tests.
Issues #4457, #4273.