Dockerfile: use bats-core #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure is unrelated (it's a flaky C/R test which is actually fixed by #2332) |
|
rebased to re-kick ci |
|
OK, CI failures caused by github being (partially) down. Restarted. |
|
OK we're again hitting a test case bug fixed by #2332 :( |
The bats testing framework we use for integration test is not maintained since 2015 and was superceded by bats-core [1]. More to say, we were using an unreleased version and relying on some features of it (unfortunately I don't remember now what are those features exactly). As Debian still packages very old version of bats from the old repo, so let's Use recent bats-core from the new, supposedly better maintained, github repo. [1] sstephenson/bats#269 Signed-off-by: Kir Kolyshkin <[email protected]>
|
rebased to fix ci |
|
@cyphar @AkihiroSuda ptal |
|
LGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a replacement for #2307, see some initial discussion in there
The bats testing framework we use for integration test is not maintained
since 2015 and was superceded by bats-core [1]. More to say, we were
using an unreleased version and relying on some features of it
(unfortunately I don't remember now what are those features exactly).
As Debian still packages very old version of bats from the old repo,
so let's Use recent bats-core from the new, supposedly better maintained,
github repo.
[1] sstephenson/bats#269