Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate gnoi cert service #208

Merged
merged 4 commits into from
Aug 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 55 additions & 53 deletions cert/cert.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 30 additions & 9 deletions cert/cert.proto
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

//
// DEPRECATION NOTICE: This API will be removed as it has been replaced via
// gNSI Certz service. This will be removed in the v1 release of the gNOI API.
//
// This file defines the gNOI API to be used for certificate installation and
// rotation.
syntax = "proto3";
Expand Down Expand Up @@ -90,7 +93,9 @@ service CertificateManagement {
// Step 6: Final commit.
// Client ---> FinalizeRequest ----> Target
rpc Rotate(stream RotateCertificateRequest)
returns (stream RotateCertificateResponse);
returns (stream RotateCertificateResponse) {
option deprecated = true;
};

// Install will put a new Certificate on the target by creating a new CSR
// request and placing the new Certificate based on the CSR on the target.The
Expand Down Expand Up @@ -135,32 +140,48 @@ service CertificateManagement {
// Client <- LoadCertificateResponse() <--- Target
//
rpc Install(stream InstallCertificateRequest)
returns (stream InstallCertificateResponse);
returns (stream InstallCertificateResponse) {
option deprecated = true;
};

// When credentials are generated on the device, generates a keypair and
// returns the Certificate Signing Request (CSR). The CSR has the public key,
// which when signed by the CA, becomes the Certificate.
rpc GenerateCSR(GenerateCSRRequest) returns (GenerateCSRResponse);
rpc GenerateCSR(GenerateCSRRequest) returns (GenerateCSRResponse) {
option deprecated = true;
};

// Loads a certificate signed by a Certificate Authority (CA).
rpc LoadCertificate(LoadCertificateRequest) returns (LoadCertificateResponse);
rpc LoadCertificate(LoadCertificateRequest)
returns (LoadCertificateResponse) {
option deprecated = true;
};

// Loads a bundle of CA certificates.
rpc LoadCertificateAuthorityBundle(LoadCertificateAuthorityBundleRequest)
returns (LoadCertificateAuthorityBundleResponse);
returns (LoadCertificateAuthorityBundleResponse) {
option deprecated = true;
};

// An RPC to get the certificates on the target.
rpc GetCertificates(GetCertificatesRequest) returns (GetCertificatesResponse);
rpc GetCertificates(GetCertificatesRequest)
returns (GetCertificatesResponse) {
option deprecated = true;
};

// An RPC to revoke specific certificates.
// If a certificate is not present on the target, the request should silently
// succeed. Revoking a certificate should render the existing certificate
// unusable by any endpoints.
rpc RevokeCertificates(RevokeCertificatesRequest)
returns (RevokeCertificatesResponse);
returns (RevokeCertificatesResponse) {
option deprecated = true;
};

// An RPC to ask a target if it can generate a Certificate.
rpc CanGenerateCSR(CanGenerateCSRRequest) returns (CanGenerateCSRResponse);
rpc CanGenerateCSR(CanGenerateCSRRequest) returns (CanGenerateCSRResponse) {
option deprecated = true;
};
}

// Request messages to rotate existing certificates on the target.
Expand Down
Loading
Loading