Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with PDFKit #977

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Experiment with PDFKit #977

wants to merge 1 commit into from

Conversation

Betree
Copy link
Member

@Betree Betree commented Dec 26, 2023

For opencollective/opencollective#6707

Benefits:

  • Can be deployed on Vercel
  • Faster
  • Future-proof
  • Ability to use custom fonts
  • Styling is more predictable

Downsides:

  • Not able to re-use our frontend components

@Betree Betree self-assigned this Dec 26, 2023
Copy link

vercel bot commented Dec 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencollective-pdf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2023 3:25pm

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3fb9f5) 65.40% compared to head (69d84ce) 65.40%.

❗ Current head 69d84ce differs from pull request most recent head b99ac09. Consider uploading reports for the commit b99ac09 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #977   +/-   ##
=======================================
  Coverage   65.40%   65.40%           
=======================================
  Files          15       15           
  Lines         318      318           
  Branches      130      130           
=======================================
  Hits          208      208           
  Misses         89       89           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants