Include collectives in organization(s) and sponsor(s) member stats #503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #502 I found out that when fetching organisations/sponsors for the banner the type that will be fetched from the api gets set to
ORGANIZATION
andCOLLECTIVE
:opencollective-images/src/server/lib/graphql.js
Lines 205 to 209 in f2ca296
When fetching the member stats (for the badge) you only count organizations however, but not collectives:
opencollective-images/src/server/lib/graphql.js
Lines 110 to 111 in f2ca296
Isn't that inconsistent?
Either you should never take into account collectives or add them to the stats as well (what my pull request does).
If you think the former is better, feel free to close this pull request, I can add another one removing
COLLECTIVE
from the first code snippet.