Add action to decline expense invite and display expense invite notes #10645
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hdiniz
force-pushed
the
decline-expense-invite
branch
from
adf4bed
to
2c9364f
Compare
The API is ready for review. It covers the decline action and notifications for updates to the invited expense. The front end is currently functional as a sketch, I will iterate on the UX. fyi: the child collective search will be on a different PR (wip) |
hdiniz
force-pushed
the
decline-expense-invite
branch
from
317a444
to
25f40f4
Compare
hdiniz
force-pushed
the
decline-expense-invite
branch
from
25f40f4
to
e01ec9d
Compare
There was a problem hiding this comment.
Button positioning
Are we sure about the button positioning? It seems a bit off to me:
As a simple fix, we could simply align it with the title: 
But I would argue that this is part of a larger problem: people who arrive here have little to no context about what Open Collective is, so it could be nice to help them understand by adding a small message (if !LoggedInUser && Boolean(draftKey)). We can surely re-use the design here to do something like:
Max height on message
To avoid getting stuck with no ability to edit, submit or cancel.
Kooha-2024-09-11-11-38-39.mp4
Related issues found while testing (not related to this PR):
hdiniz
force-pushed
the
decline-expense-invite
branch
from
e01ec9d
to
7ff2442
Compare
|
Made changes to align with the new expense design: |
Related opencollective/opencollective#7535
Require opencollective/opencollective-api#10307
Description
Users invited to an expense should be presented with the invitation notes to give context, and they should be able to decline the invite with some comment.