Await activity creation to avoid deadlocks when running tests #9459
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @gustavlrsn and the rest of your teammates on |
gustavlrsn
force-pushed
the
11-07-Await_activity_creation_to_avoid_deadlocks
branch
from
9f744f0
to
d993524
Compare
gustavlrsn
changed the title
gustavlrsn
force-pushed
the
11-07-Await_activity_creation_to_avoid_deadlocks
branch
from
d993524
to
568ec2a
Compare
There was a problem hiding this comment.
I like the idea of waiting for activities creation; I'm not a big fan of throwing Promises without looking at their result. We have many other places like that which would need to be updated if we want to make it a global change.
My main concern with the way it has been done here is that it actually changes the behavior in case there's a crash in the activity creation: we'll now return an error saying that the collective/event/fund/project creation failed, which is not true.
I'd recommend, inside generateCollectiveCreatedActivity, to wrap the activity creation call in a try ... catch, reporting the error to Sentry without re-throwing it if there's an issue.
No description provided.