Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct gene.id modification warning message. #1424

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

mdziurzynski
Copy link

Unlike with metabolites or reactions, direct modification of Gene class id property may lead implicit gene duplications in the model. The user should be notified that there is a special, safe function designed just for that.

Im just not quite sure about the super(Gene, self.__class__).id.fset(self, new_id) syntax and will welcome any comments.

@Midnighter
Copy link
Member

I think that modifying the ID can cause so many issues that we should consider disallowing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants