Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial trace module #1

Merged
merged 5 commits into from
Dec 18, 2018
Merged

initial trace module #1

merged 5 commits into from
Dec 18, 2018

Conversation

tsloughter
Copy link
Member

Thoughts?

hauleth
hauleth requested changes Dec 14, 2018
View reviewed changes
Copy link
Member

@hauleth hauleth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be wary of using macros and unless you wan to do anything in compile time then I would avoid them.

lib/opencensus/trace.ex Outdated Show resolved Hide resolved
lib/opencensus/trace.ex Outdated Show resolved Hide resolved
lib/opencensus/trace.ex Outdated Show resolved Hide resolved
@tsloughter
Copy link
Member Author

I like the macro, and usually I hate macros.

@hauleth
Copy link
Member

hauleth commented Dec 14, 2018

But there is no point in using macro except making it slightly "nicer" by using do … end syntax. For me it is pointless and potentially can cause weird error reports. It would make sense if you would provide context as the attributes. That is why I have created census-instrumentation/opencensus-erlang#112, in that case it would make sense ;)

tsloughter and others added 2 commits December 14, 2018 16:57
@tsloughter
use optional arguments to combine the macros
e7cd2f0
@hauleth
feat: provide additional context for span
94f878d 
It adds additional context to the span, namely:

- module
- line
- function where span started
- file
@tsloughter
Merge pull request #1 from hauleth/additional-context
065067f 
Provide additional context for span
@tsloughter tsloughter merged commit efec29d into opencensus-beam:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauleth hauleth hauleth approved these changes

@deadtrickster deadtrickster Awaiting requested review from deadtrickster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsloughter @hauleth