Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Details Modals #909

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Sep 11, 2024

Reduces duplicate code by creating a "DetailsModal" component for e.g. event details or user details.
Functionality should be unchanged, but there may be some slight CSS changes.

@Arnei Arnei added the type:code-enhancement Internal improvements to the codebase label Sep 11, 2024
Reduces duplicate code by creating a "DetailsModal"
component for e.g. event details or user details.
Functionality should be unchanged, but there may
be some slight CSS changes.
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-909

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-909

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Sep 11, 2024

This pull request is deployed at test.admin-interface.opencast.org/909/2024-09-11_08-45-01/ .
It might take a few minutes for it to become available.

@Arnei Arnei changed the title Unify Details Modal Unify Details Modals Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:code-enhancement Internal improvements to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant