Add additional features for Tobira integration #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
This was referenced Aug 12, 2024
owi92
force-pushed
the
tobira-things
branch
2 times, most recently
from
eb18e6e
to
89d6d5f
Compare
|
This pull request is deployed at test.admin-interface.opencast.org/878/2024-09-18_09-45-13/ . |
|
I tried to make the Tobira tabs a little less "matryoschka"-like, as suggested in todays technical Meeting. This does however mean that these tabs won't follow the design examples set by other tabs. They are still built like russian dolls (I didn't come up with that analogy but it's fitting). Some updated screenshots: |
owi92
force-pushed
the
tobira-things
branch
5 times, most recently
from
3838172
to
9f543db
Compare
|
This pull request has conflicts ☹ |
Merged
This adapts the Tobira details component from series details to be usable in both series and event context. Note that an Opencast patch (todo: link that patch) is necessary for this to work.
This was requested by Bern. It is still possible to select and deselect the path by clicking it's name, but next to that a checkbox was added for visual clarity. The checkbox is only shown when the path can be selected (the page needs to be empty).
This factors out some code and applies some (yet non-inforced) linting rules, ES6 syntax and formatting to limit some indentation levels and improve readability.
Another feature requested by Bern, this adds the necessary API and UI functions/components to edit existing series paths. Editing is only allowed if the page with that path has no other blocks than that of the series.
This pulls the code into a component to limit duplication. The component can be used when "cancel" and "save" buttons are needed in modal tabs that allow editing things like access policies. This makes it easier to reuse and limits duplicated code.
Most notably the series title (in Tobira context) was made optional, so we don't have to pass an empty string to Tobira when it's not specified.
This came up and was suggested in the technical meeting. It does however mean that the Tobira tab will not really follow the examplary design-"principles" of the other tabs.
Previously I had them hidden if they couldn't be checked. After some feedback from Bern we decided to show them anyway, but add a tooltip to explain why they can't be checked. The disabled style isn't really that striking or self explanatory. I hope this will prevent at least some confusion.
503 errors mean that Tobira either isn't configured, or not configured correcty in Opencast. Unfortunately, it doesn't distinguish between the two. Since it might very well be the former, I think we shouldn't show the error as a notification in the UI. Instead there will be an info in console saying "Tobira isn't configured (correctly)" and the Tobira tab will be hidden. This solution isn't optimal but I think it's the best we can do for now. The other errors (404, 500) will trigger notifications that are shown in the respective Tobira tab.
owi92
force-pushed
the
tobira-things
branch
from
9f543db
to
fc0ebb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds most of the additional requirements in #311.
Needs elan-ev/tobira#1225 and opencast/opencast#6091 to work correctly.
Only the last
710 commits need to be reviewed here, as the rest is based on #313.Key changes/features:
(Edit: see updated screenshots in my comment further below)
The event details modal now has a Tobira tab which provides a direct link and list any pages in Tobira that feature the event:
The Tobira tab of the series details modal got the addition of an "edit path" button that lets admins edit paths of series that are already mounted in Tobira (with the condition that the page where the series is mounted does not contain any other blocks)
Selectable pages for adding and moving (i.e. updating the path of) series now feature an additional checkbox that shows which page is currently selected (and selectable at all)
Notable omissions/deviations:
If these omissions are dealbreakers, we should discuss them in an upcoming meeting.
Note: This PR is based on #313 which adds the Tobira integration. That should definitely be merged prior to this one! (it's only been open for like 4 months..)
I'll mark this as a draft until #313 is merged.
Closes #311