Fix required metadata not being required #800
Conversation
Fix typescript errors in validates.ts
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
Arnei
force-pushed
the
validate-metadata-dynamically
branch
from
b2bca2a
to
e1d6c40
Compare
|
This pull request is deployed at test.admin-interface.opencast.org/800/2024-09-16_07-34-33/ . |
In the backend, metadata catalogs can be configured as needed. One thing that can be configured for each metadata field is if is considered required. A user should not be able to leave a required field empty (or set it to empty). Our validation was ignoring said configuration, merely enforcing the title field. This fixes the issue by dynamically creating a validation schema based on configuration for the existing metadata fields. Although it really feels like Yup does not want me to do this.
Arnei
force-pushed
the
validate-metadata-dynamically
branch
from
e1d6c40
to
d721382
Compare
|
Does what it says on the tin. Does not address the series side of things, which has the same options (at least in the config file). Is that something you want to address here since I'm assuming the logic would be more or less copy+paste? |
|
Series side addressed (I think. Have not looked at this code in a while.) |
In the backend, metadata catalogs can be configured as needed. One thing that can be configured for each metadata field is if is considered required. A user should not be able to leave a required field empty (or set it to
empty). Our validation was ignoring said configuration, merely enforcing the title field.
This fixes the issue by dynamically creating a validation schema based on configuration for the existing metadata fields. Although it really feels like Yup does not want me to do this.
Fixes #317.
Includes #798.