Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for various config options in listprovider/acl.default.create.properties #741

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add support for various config options in listprovider/acl.default.create.properties #741

wants to merge 5 commits into from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jun 25, 2024

This should add support for

  • read_enabled
  • write_enabled
  • read_readonly
  • write_readonly
  • default_actions
  • keep_on_template_switch_role_prefixes

To review, check listprovider/acl.default.create.properties in your Opencast , read what the options are all about and fiddle around with them.

There are two more config options in the listprovider that this does not add support for. Those two options were required for opencast/opencast#4487, but are essentially code duplication and as such I would like to avoid using them.

Helps with #409.

@Arnei
Respect listprovider option keep_on_template_switch_role_prefixes
b402d7e 
The listprovider file listproviders/acl.defaults.create.properties
defines keep_on_template_switch_role_prefixes
which allows certain roles to be kept when
switchting between ACL templates in the
various details views. The new admin ui
did not respect this option yet.
@Arnei
Support more settings from listprovider/acl.default.create.properties
63940cd 
Adds support for a couple more config options,
that should make creating new acls a little more
comfortable.
@Arnei Arnei added the type:bug Something isn't working label Jun 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-741

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-741

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 25, 2024 •
edited
Loading

This pull request is deployed at test.admin-interface.opencast.org/741/2024-09-05_08-18-36/ .
It might take a few minutes for it to become available.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Arnei