Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata validation does not respect "required" for any field other than "title" #317

Open
Arnei opened this issue Apr 4, 2024 · 0 comments · May be fixed by #800
Open

Metadata validation does not respect "required" for any field other than "title" #317

Arnei opened this issue Apr 4, 2024 · 0 comments · May be fixed by #800
Assignees
Labels
type:bug Something isn't working

Comments

@Arnei
Copy link
Member

Arnei commented Apr 4, 2024

When creating a new event or series, certain metadata fields can be required, meaning they have to have a value before the user can proceed to the next step. Usually, only the title field for the common metadata catalog is required, but users can change that in the backend.

Unfortunately, our validation for metadata fields is hardcoded and as such only checks if there is a value for title. Should another field be marked as required, this will be correctly shown in the ui, but will not be respected by validation. For example, `description* may also be marked as required, but the user can proceed to the next step without having entered any description.

To properly solve this, we would need to make our static validation dynamic, based on the metadata catalogs schemas from the backend.

@Arnei Arnei added the type:bug Something isn't working label Apr 4, 2024
@lkiesow lkiesow added the bugbash label Jun 5, 2024
@ciegler ciegler self-assigned this Jun 5, 2024
@lkiesow lkiesow removed the bugbash label Jul 2, 2024
@Arnei Arnei linked a pull request Jul 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants