Cache type changes at OCPL #595
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed old GeoPath Final / podcache - changed cache id for moving & owncache - added 4 new cache types *** - added graphical resources, new and missing.
+ small correction in code
following5
reviewed
Oct 26, 2019
| <li>(Types may be added or removed. Your application MUST be | ||
| prepared for any new types and may handle them as "Other".)</li> | ||
| </ul> | ||
| <p>There are even more types, but OKAPI maps them to common types | ||
| <p>Opencaching cache types are documented | ||
| <a href="https://wiki.opencaching.eu/index.php?title=Cache_types" target="_blank">here</a></p> |
There was a problem hiding this comment.
Everthing OKAPI developers need to know should be documented here, so it is not necessary to reference any external documentation. To avoid redundancy and all its inherent problems, I suggest to remove this reference from OKAPI docs.
|
This PR changes the internal OCPL ID of Moving caches from 8 to 9. Please be aware of the consequences of such renumbering:
I don't see any benefit by this renumbering and recommend not to do it - it just produces additional work and can introduce bugs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles changes described here: #594 and is paired with this PR at OCPL: opencaching/opencaching-pl#2087