Dev - planning #34
Open
Dev - planning #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull master commits into new-loop
… tight loop to avoid stepping on other pi's
Conflicts: bin/loop.sh
…ve to all succeed on the same run
…e false positives)
Look what you started @audiefile. ;)
Wip/bewest/tweaks notify
…tform/soc/3f980000.usb/buspower and use whichever exists
…low, or units are wrong
…to wip/more-failsafes
Eliminate illegal js, break keyword is not allowed outside of loops/switches.
Cause process to error out in case of mmol.
Prevent errors like this:
foo$ oref0-get-profile monitor/pump-history.json tagrgets-mm
ol.json
/usr/local/lib/node_modules/openaps-js/bin/oref0-get-profile.js:50
break;
^^^^^
SyntaxError: Illegal break statement
at Module._compile (module.js:439:25)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Function.Module.runMain (module.js:497:10)
at startup (node.js:119:16)
at node.js:901:3
bewest@hither:~/Documents/foo$
In favor of errors like this:
o$ oref0-get-profile monitor/pump-history.json tagrgets-mmol.json monitor/insulin-sensitivities.json monitor/active-basal-profile.json monitor/carb-ratios.json max_iob.json
BG Target data is expected to be expressed in mg/dL. Found mmol/L in tagrgets-mmol.json .
bewest@hither:~/Documents/foo$
If the file names don't match, the package will refuse to install.
Make simpler modules that can be require'd, tested, and re-used with ease.
add fail and warmup utilities
Wip/refactor/testable reusable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
planning next version