Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add state management to the dumper to ease resumption #91

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ramSeraph
Copy link
Contributor

state can be serialised to disk and used to skip already handled features

Submitting the PR, to see if there is interest in this feature, given the amount of code changes, I wouldn't mind maintaining it separately if it is too much of a review burden.

TODO:

  • Add tests for the state management code
  • provide support to specify state file in the cli

@ramSeraph
Copy link
Contributor Author

ramSeraph commented Nov 14, 2022

Existing tests pass, and state management for all modes except the query by geographical extent were used and known to work.

@ramSeraph
Copy link
Contributor Author

@iandees
Copy link
Member

iandees commented Nov 18, 2022

Thanks for submitting this. I'm still thinking about if this is something I want to support in the library directly.

@ramSeraph
Copy link
Contributor Author

I too think a lot of it can be outside the library, but some encapsulation of params for different modes might need to be in the library to support something similar to the cli "start_with" for all modes.

Your call, also not urgent at all :)

state can be serialized to disk and used to skip already handled
features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants