Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] Update rails 7.0.8.1 β†’ 7.1.3.4 (minor) #3416

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jun 14, 2024


🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!


Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rails (7.0.8.1 β†’ 7.1.3.4) Β· Repo

Security Advisories 🚨

🚨 Rails has possible XSS Vulnerability in Action Controller

Possible XSS Vulnerability in Action Controller

There is a possible XSS vulnerability when using the translation helpers
(translate, t, etc) in Action Controller. This vulnerability has been
assigned the CVE identifier CVE-2024-26143.

Versions Affected: >= 7.0.0.
Not affected: < 7.0.0
Fixed Versions: 7.1.3.1, 7.0.8.1

Impact

Applications using translation methods like translate, or t on a
controller, with a key ending in "_html", a :default key which contains
untrusted user input, and the resulting string is used in a view, may be
susceptible to an XSS vulnerability.

For example, impacted code will look something like this:

class ArticlesController < ApplicationController
  def show  
    @message = t("message_html", default: untrusted_input)
    # The `show` template displays the contents of `@message`
  end
end

To reiterate the pre-conditions, applications must:

  • Use a translation function from a controller (i.e. not I18n.t, or t from
    a view)
  • Use a key that ends in _html
  • Use a default value where the default value is untrusted and unescaped input
  • Send the text to the victim (whether that's part of a template, or a
    render call)

All users running an affected release should either upgrade or use one of the
workarounds immediately.

Releases

The fixed releases are available at the normal locations.

Workarounds

There are no feasible workarounds for this issue.

Patches

To aid users who aren't able to upgrade immediately we have provided patches for
the two supported release series. They are in git-am format and consist of a
single changeset.

  • 7-0-translate-xss.patch - Patch for 7.0 series
  • 7-1-translate-xss.patch - Patch for 7.1 series

Credits

Thanks to ooooooo_q for the patch and fix!

Release Notes

7.1.3.4

More info than we can show here.

7.1.3.3

More info than we can show here.

7.1.3.2

More info than we can show here.

7.1.3.1

More info than we can show here.

7.1.3

More info than we can show here.

7.1.2

More info than we can show here.

7.1.1

More info than we can show here.

7.1.0

More info than we can show here.

7.0.8.4

More info than we can show here.

7.0.8.2

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ actioncable (indirect, 7.0.8.1 β†’ 7.1.3.4) Β· Repo Β· Changelog

Release Notes

7.1.3.4 (from changelog)

More info than we can show here.

7.1.3.3 (from changelog)

More info than we can show here.

7.1.3.2 (from changelog)

More info than we can show here.

7.1.3.1 (from changelog)

More info than we can show here.

7.1.3 (from changelog)

More info than we can show here.

7.1.2 (from changelog)

More info than we can show here.

7.1.1 (from changelog)

More info than we can show here.

7.1.0 (from changelog)

More info than we can show here.

7.0.8.4 (from changelog)

More info than we can show here.

7.0.8.3 (from changelog)

More info than we can show here.

7.0.8.2 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ actionmailbox (indirect, 7.0.8.1 β†’ 7.1.3.4) Β· Repo Β· Changelog

↗️ actionmailer (indirect, 7.0.8.1 β†’ 7.1.3.4) Β· Repo Β· Changelog

Release Notes

7.1.3.4 (from changelog)

More info than we can show here.

7.1.3.3 (from changelog)

More info than we can show here.

7.1.3.2 (from changelog)

More info than we can show here.

7.1.3.1 (from changelog)

More info than we can show here.

7.1.3 (from changelog)

More info than we can show here.

7.1.2 (from changelog)

More info than we can show here.

7.1.1 (from changelog)

More info than we can show here.

7.1.0 (from changelog)

More info than we can show here.

7.0.8.4 (from changelog)

More info than we can show here.

7.0.8.3 (from changelog)

More info than we can show here.

7.0.8.2 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ actionpack (indirect, 7.0.8.1 β†’ 7.1.3.4) Β· Repo Β· Changelog

Security Advisories 🚨

🚨 Missing security headers in Action Pack on non-HTML responses

Permissions-Policy is Only Served on HTML Content-Type

The application configurable Permissions-Policy is only served on responses
with an HTML related Content-Type.

This has been assigned the CVE identifier CVE-2024-28103.

Versions Affected: >= 6.1.0
Not affected: < 6.1.0
Fixed Versions: 6.1.7.8, 7.0.8.4, and 7.1.3.4

Impact

Responses with a non-HTML Content-Type are not serving the configured Permissions-Policy. There are certain non-HTML Content-Types that would benefit from having the Permissions-Policy enforced.

Releases

The fixed releases are available at the normal locations.

Workarounds

N/A

Patches

To aid users who aren't able to upgrade immediately we have provided patches for
the supported release series in accordance with our
maintenance policy
regarding security issues. They are in git-am format and consist of a
single changeset.

  • 6-1-include-permissions-policy-header-on-non-html.patch - Patch for 6.1 series
  • 7-0-include-permissions-policy-header-on-non-html.patch - Patch for 7.0 series
  • 7-1-include-permissions-policy-header-on-non-html.patch - Patch for 7.1 series

Credits

Thank you shinkbr for reporting this!

🚨 Missing security headers in Action Pack on non-HTML responses

Permissions-Policy is Only Served on HTML Content-Type

The application configurable Permissions-Policy is only served on responses
with an HTML related Content-Type.

This has been assigned the CVE identifier CVE-2024-28103.

Versions Affected: >= 6.1.0
Not affected: < 6.1.0
Fixed Versions: 6.1.7.8, 7.0.8.4, and 7.1.3.4

Impact

Responses with a non-HTML Content-Type are not serving the configured Permissions-Policy. There are certain non-HTML Content-Types that would benefit from having the Permissions-Policy enforced.

Releases

The fixed releases are available at the normal locations.

Workarounds

N/A

Patches

To aid users who aren't able to upgrade immediately we have provided patches for
the supported release series in accordance with our
maintenance policy
regarding security issues. They are in git-am format and consist of a
single changeset.

  • 6-1-include-permissions-policy-header-on-non-html.patch - Patch for 6.1 series
  • 7-0-include-permissions-policy-header-on-non-html.patch - Patch for 7.0 series
  • 7-1-include-permissions-policy-header-on-non-html.patch - Patch for 7.1 series

Credits

Thank you shinkbr for reporting this!

🚨 Rails has possible ReDoS vulnerability in Accept header parsing in Action Dispatch

Possible ReDoS vulnerability in Accept header parsing in Action Dispatch

There is a possible ReDoS vulnerability in the Accept header parsing routines
of Action Dispatch. This vulnerability has been assigned the CVE identifier
CVE-2024-26142.

Versions Affected: >= 7.1.0, < 7.1.3.1
Not affected: < 7.1.0
Fixed Versions: 7.1.3.1

Impact

Carefully crafted Accept headers can cause Accept header parsing in Action
Dispatch to take an unexpected amount of time, possibly resulting in a DoS
vulnerability. All users running an affected release should either upgrade or
use one of the workarounds immediately.

Ruby 3.2 has mitigations for this problem, so Rails applications using Ruby
3.2 or newer are unaffected.

Releases

The fixed releases are available at the normal locations.

Workarounds

There are no feasible workarounds for this issue.

Patches

To aid users who aren't able to upgrade immediately we have provided patches for
the two supported release series. They are in git-am format and consist of a
single changeset.

  • 7-1-accept-redox.patch - Patch for 7.1 series

Credits

Thanks svalkanov for the report and patch!

🚨 Rails has possible XSS Vulnerability in Action Controller

Possible XSS Vulnerability in Action Controller

There is a possible XSS vulnerability when using the translation helpers
(translate, t, etc) in Action Controller. This vulnerability has been
assigned the CVE identifier CVE-2024-26143.

Versions Affected: >= 7.0.0.
Not affected: < 7.0.0
Fixed Versions: 7.1.3.1, 7.0.8.1

Impact

Applications using translation methods like translate, or t on a
controller, with a key ending in "_html", a :default key which contains
untrusted user input, and the resulting string is used in a view, may be
susceptible to an XSS vulnerability.

For example, impacted code will look something like this:

class ArticlesController < ApplicationController
  def show  
    @message = t("message_html", default: untrusted_input)
    # The `show` template displays the contents of `@message`
  end
end

To reiterate the pre-conditions, applications must:

  • Use a translation function from a controller (i.e. not I18n.t, or t from
    a view)
  • Use a key that ends in _html
  • Use a default value where the default value is untrusted and unescaped input
  • Send the text to the victim (whether that's part of a template, or a
    render call)

All users running an affected release should either upgrade or use one of the
workarounds immediately.

Releases

The fixed releases are available at the normal locations.

Workarounds

There are no feasible workarounds for this issue.

Patches

To aid users who aren't able to upgrade immediately we have provided patches for
the two supported release series. They are in git-am format and consist of a
single changeset.

  • 7-0-translate-xss.patch - Patch for 7.0 series
  • 7-1-translate-xss.patch - Patch for 7.1 series

Credits

Thanks to ooooooo_q for the patch and fix!

Release Notes

7.1.3.4 (from changelog)

More info than we can show here.

7.1.3.3 (from changelog)

More info than we can show here.

7.1.3.2 (from changelog)

More info than we can show here.

7.1.3.1 (from changelog)

More info than we can show here.

7.1.3 (from changelog)

More info than we can show here.

7.1.2 (from changelog)

More info than we can show here.

7.1.1 (from changelog)

More info than we can show here.

7.1.0 (from changelog)

More info than we can show here.

7.0.8.4 (from changelog)

More info than we can show here.

7.0.8.3 (from changelog)

More info than we can show here.

7.0.8.2 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ actiontext (indirect, 7.0.8.1 β†’ 7.1.3.4) Β· Repo Β· Changelog

Security Advisories 🚨

🚨 ActionText ContentAttachment can Contain Unsanitized HTML

Instances of ActionText::Attachable::ContentAttachment included within a rich_text_area tag could potentially contain unsanitized HTML.

This has been assigned the CVE identifier CVE-2024-32464.

Versions Affected: >= 7.1.0
Not affected: < 7.1.0
Fixed Versions: 7.1.3.4

Impact

This could lead to a potential cross site scripting issue within the Trix editor.

Releases

The fixed releases are available at the normal locations.

Workarounds

N/A

Patches

To aid users who aren't able to upgrade immediately we have provided patches for the supported release series in accordance with our maintenance policy regarding security issues. They are in git-am format and consist of a single changeset.

  • action_text_content_attachment_xss_7_1_stable.patch - Patch for 7.1 series

Credits

Thank you ooooooo_q for reporting this!

🚨 Trix Editor Arbitrary Code Execution Vulnerability

The Trix editor, versions prior to 2.1.1, is vulnerable to arbitrary code execution when copying and pasting content from the web or other documents with markup into the editor. The vulnerability stems from improper sanitization of pasted content, allowing an attacker to embed malicious scripts which are executed within the context of the application.

Vulnerable Versions:

  • 1.x series up to and including 1.3.1
  • 2.x series up to and including 2.1.0

Fixed Versions:

  • v1.3.2
  • v2.1.1

Vector:

  • Bug 1: When copying content manipulated by a script, such as:
document.addEventListener('copy', function(e){
  e.clipboardData.setData('text/html', '<div><noscript><div class="123</noscript>456<img src=1 onerror=alert(1)//"></div></noscript></div>');
  e.preventDefault();
});

and pasting into the Trix editor, the script within the content is executed.

  • Bug 2: Similar execution occurs with content structured as:
document.write(`copy<div data-trix-attachment="{&quot;contentType&quot;:&quot;text/html&quot;,&quot;content&quot;:&quot;&lt;img src=1 onerror=alert(101)&gt;HELLO123&quot;}"></div>me`);

Impact:

An attacker could exploit these vulnerabilities to execute arbitrary JavaScript code within the context of the user's session, potentially leading to unauthorized actions being performed or sensitive information being disclosed.

Remediation:

Update Recommendation: Users should upgrade to Trix editor version 2.1.1 or later, which incorporates proper sanitization of input from copied content.

CSP Enhancement: Additionally, enhancing the Content Security Policy (CSP) to disallow inline scripts can significantly mitigate the risk of such vulnerabilities. Set CSP policies such as script-src 'self' to ensure that only scripts hosted on the same origin are executed, and explicitly prohibit inline scripts using script-src-elem.

References:

Credit: These issues were reported by security researchers loknop and pinpie.

🚨 Trix Editor Arbitrary Code Execution Vulnerability

The Trix editor, versions prior to 2.1.1, is vulnerable to arbitrary code execution when copying and pasting content from the web or other documents with markup into the editor. The vulnerability stems from improper sanitization of pasted content, allowing an attacker to embed malicious scripts which are executed within the context of the application.

Vulnerable Versions:

  • 1.x series up to and including 1.3.1
  • 2.x series up to and including 2.1.0

Fixed Versions:

  • v1.3.2
  • v2.1.1

Vector:

  • Bug 1: When copying content manipulated by a script, such as:
document.addEventListener('copy', function(e){
  e.clipboardData.setData('text/html', '<div><noscript><div class="123</noscript>456<img src=1 onerror=alert(1)//"></div></noscript></div>');
  e.preventDefault();
});

and pasting into the Trix editor, the script within the content is executed.

  • Bug 2: Similar execution occurs with content structured as:
document.write(`copy<div data-trix-attachment="{&quot;contentType&quot;:&quot;text/html&quot;,&quot;content&quot;:&quot;&lt;img src=1 onerror=alert(101)&gt;HELLO123&quot;}"></div>me`);

Impact:

An attacker could exploit these vulnerabilities to execute arbitrary JavaScript code within the context of the user's session, potentially leading to unauthorized actions being performed or sensitive information being disclosed.

Remediation:

Update Recommendation: Users should upgrade to Trix editor version 2.1.1 or later, which incorporates proper sanitization of input from copied content.

CSP Enhancement: Additionally, enhancing the Content Security Policy (CSP) to disallow inline scripts can significantly mitigate the risk of such vulnerabilities. Set CSP policies such as script-src 'self' to ensure that only scripts hosted on the same origin are executed, and explicitly prohibit inline scripts using script-src-elem.

References:

Credit: These issues were reported by security researchers loknop and pinpie.

Release Notes

7.1.3.4 (from changelog)

More info than we can show here.

7.1.3.3 (from changelog)

More info than we can show here.

7.1.3.2 (from changelog)

More info than we can show here.

7.1.3.1 (from changelog)

More info than we can show here.

7.1.3 (from changelog)

More info than we can show here.

7.1.2 (from changelog)

More info than we can show here.

7.1.1 (from changelog)

More info than we can show here.

7.1.0 (from changelog)

More info than we can show here.

7.0.8.4 (from changelog)

More info than we can show here.

7.0.8.3 (from changelog)

More info than we can show here.

7.0.8.2 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ actionview (indirect, 7.0.8.1 β†’ 7.1.3.4) Β· Repo Β· Changelog

Release Notes

7.1.3.4 (from changelog)

More info than we can show here.

7.1.3.3 (from changelog)

More info than we can show here.

7.1.3.2 (from changelog)

More info than we can show here.

7.1.3.1 (from changelog)

More info than we can show here.

7.1.3 (from changelog)

More info than we can show here.

7.1.2 (from changelog)

More info than we can show here.

7.1.1 (from changelog)

More info than we can show here.

7.1.0 (from changelog)

More info than we can show here.

7.0.8.4 (from changelog)

More info than we can show here.

7.0.8.3 (from changelog)

More info than we can show here.

7.0.8.2 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ activejob (indirect, 7.0.8.1 β†’ 7.1.3.4) Β· Repo Β· Changelog

Release Notes

7.1.3.4 (from changelog)

More info than we can show here.

7.1.3.3 (from changelog)

More info than we can show here.

7.1.3.2 (from changelog)

More info than we can show here.

7.1.3.1 (from changelog)

More info than we can show here.

7.1.3 (from changelog)

More info than we can show here.

7.1.2 (from changelog)

More info than we can show here.

7.1.1 (from changelog)

More info than we can show here.

7.1.0 (from changelog)

More info than we can show here.

7.0.8.4 (from changelog)

More info than we can show here.

7.0.8.3 (from changelog)

More info than we can show here.

7.0.8.2 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ activemodel (indirect, 7.0.8.1 β†’ 7.1.3.4) Β· Repo Β· Changelog

Release Notes

7.1.3.4 (from changelog)

More info than we can show here.

7.1.3.3 (from changelog)

More info than we can show here.

7.1.3.2 (from changelog)

More info than we can show here.

7.1.3.1 (from changelog)

More info than we can show here.

7.1.3 (from changelog)

More info than we can show here.

7.1.2 (from changelog)

More info than we can show here.

7.1.1 (from changelog)

More info than we can show here.

7.1.0 (from changelog)

More info than we can show here.

7.0.8.4 (from changelog)

More info than we can show here.

7.0.8.3 (from changelog)

More info than we can show here.

7.0.8.2 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ activerecord (indirect, 7.0.8.1 β†’ 7.1.3.4) Β· Repo Β· Changelog

Release Notes

7.1.3.4 (from changelog)

More info than we can show here.

7.1.3.3 (from changelog)

More info than we can show here.

7.1.3.2 (from changelog)

More info than we can show here.

7.1.3.1 (from changelog)

More info than we can show here.

7.1.3 (from changelog)

More info than we can show here.

7.1.2 (from changelog)

More info than we can show here.

7.1.1 (from changelog)

More info than we can show here.

7.1.0 (from changelog)

More info than we can show here.

7.0.8.4 (from changelog)

More info than we can show here.

7.0.8.3 (from changelog)

More info than we can show here.

7.0.8.2 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ activestorage (indirect, 7.0.8.1 β†’ 7.1.3.4) Β· Repo Β· Changelog

Release Notes

7.1.3.4 (from changelog)

More info than we can show here.

7.1.3.3 (from changelog)

More info than we can show here.

7.1.3.2 (from changelog)

More info than we can show here.

7.1.3.1 (from changelog)

More info than we can show here.

7.1.3 (from changelog)

More info than we can show here.

7.1.2 (from changelog)

More info than we can show here.

7.1.1 (from changelog)

More info than we can show here.

7.1.0 (from changelog)

More info than we can show here.

7.0.8.4 (from changelog)

More info than we can show here.

7.0.8.3 (from changelog)

More info than we can show here.

7.0.8.2 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ activesupport (indirect, 7.0.8.1 β†’ 7.1.3.4) Β· Repo Β· Changelog

Release Notes

7.1.3.4 (from changelog)

More info than we can show here.

7.1.3.3 (from changelog)

More info than we can show here.

7.1.3.2 (from changelog)

More info than we can show here.

7.1.3.1 (from changelog)

More info than we can show here.

7.1.3 (from changelog)

More info than we can show here.

7.1.2 (from changelog)

More info than we can show here.

7.1.1 (from changelog)

More info than we can show here.

7.1.0 (from changelog)

More info than we can show here.

7.0.8.4 (from changelog)

More info than we can show here.

7.0.8.3 (from changelog)

More info than we can show here.

7.0.8.2 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ railties (indirect, 7.0.8.1 β†’ 7.1.3.4) Β· Repo Β· Changelog

Release Notes

7.1.3.4 (from changelog)

More info than we can show here.

7.1.3.3 (from changelog)

More info than we can show here.

7.1.3.2 (from changelog)

More info than we can show here.

7.1.3.1 (from changelog)

More info than we can show here.

7.1.3 (from changelog)

More info than we can show here.

7.1.2 (from changelog)

More info than we can show here.

7.1.1 (from changelog)

More info than we can show here.

7.1.0 (from changelog)

More info than we can show here.

7.0.8.4 (from changelog)

More info than we can show here.

7.0.8.3 (from changelog)

More info than we can show here.

7.0.8.2 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

πŸ†• connection_pool (added, 2.4.1)

πŸ†• drb (added, 2.2.1)

πŸ†• io-console (added, 0.7.2)

πŸ†• irb (added, 1.14.0)

πŸ†• mutex_m (added, 0.2.0)

πŸ†• psych (added, 5.1.2)

πŸ†• rack-session (added, 1.0.2)

πŸ†• rackup (added, 1.0.0)

πŸ†• rdoc (added, 6.7.0)

πŸ†• reline (added, 0.5.9)

πŸ†• stringio (added, 3.1.1)

πŸ†• webrick (added, 1.8.1)

πŸ—‘οΈ method_source (removed)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu Automatic PRs to update gems label Jun 14, 2024
@hennevogel
Copy link
Member

@depfu rebase

@depfu depfu bot force-pushed the depfu/update/group/rails-7.1.3.4 branch from 2036e3d to b01fd6b Compare July 11, 2024 11:24
@hennevogel
Copy link
Member

@depfu rebase

@depfu depfu bot force-pushed the depfu/update/group/rails-7.1.3.4 branch 4 times, most recently from 76c4fe6 to 3b63bb9 Compare July 19, 2024 11:25
@depfu depfu bot force-pushed the depfu/update/group/rails-7.1.3.4 branch from 3b63bb9 to 579bbe4 Compare August 27, 2024 12:25
Copy link
Contributor Author

depfu bot commented Aug 29, 2024

Closed in favor of #3449.

@depfu depfu bot closed this Aug 29, 2024
@depfu depfu bot deleted the depfu/update/group/rails-7.1.3.4 branch August 29, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depfu Automatic PRs to update gems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant