Skip to content
This repository was archived by the owner on Dec 16, 2024. It is now read-only.

[24] - Add monitorResources, measureTime, and Cleanup Enhancements to Mojafos Scripts #35

Open
Abhinavcode13 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[24] - Add monitorResources, measureTime, and Cleanup Enhancements to Mojafos Scripts #35

Abhinavcode13 wants to merge 1 commit into from

Conversation

@Abhinavcode13
Copy link
Collaborator

@Abhinavcode13 Abhinavcode13 commented May 23, 2024 •
edited
Loading

fixes: #21 & #24

@Abhinavcode13 Abhinavcode13 changed the title Added deployment time tracking, memory, and disk space usage monitoring in mojafos bash scripts Added deployment time tracking, memory, and disk space usage monitoring in commandline.sh and config.sh May 23, 2024
@Abhinavcode13 Abhinavcode13 changed the title Added deployment time tracking, memory, and disk space usage monitoring in commandline.sh and config.sh Fix: Added deployment time tracking, memory, and disk space usage monitoring in commandline.sh and config.sh May 23, 2024
@Abhinavcode13 Abhinavcode13 changed the title Fix: Added deployment time tracking, memory, and disk space usage monitoring in commandline.sh and config.sh Fix: Add deployment time tracking, memory, and disk space usage monitoring in commandline.sh and config.sh May 23, 2024
@Abhinavcode13
Copy link
Collaborator Author

Abhinavcode13 commented May 23, 2024

changed the PR's name to be more issue-specific

@Abhinavcode13
Copy link
Collaborator Author

Abhinavcode13 commented May 25, 2024

PTAL, @elijah0kello.

@Abhinavcode13 Abhinavcode13 changed the title Fix: Add deployment time tracking, memory, and disk space usage monitoring in commandline.sh and config.sh Fix: Add deployment metrics tracking in commandline.sh and config.sh Jun 4, 2024
@Abhinavcode13 Abhinavcode13 changed the title Fix: Add deployment metrics tracking in commandline.sh and config.sh Add monitorResources, measureTime, and Cleanup Enhancements to Mojafos Scripts Jun 5, 2024
@Abhinavcode13 Abhinavcode13 mentioned this pull request Jun 16, 2024
Open
@elijah0kello
Copy link
Collaborator

elijah0kello commented Jun 19, 2024 •
edited
Loading

@Abhinavcode13 I have tried to run the code being sent it by this PR but for some reason, it looks broken.

When I execute a script, it just brings this. It does not bring the MOJAFOS welcome word at all.

It starts to just print mojaloop deployment logs.

Kindly rebase from dev and make the PR to the dev branch.

Here is evidence of the execution

Screenshot 2024-06-19 at 10 45 38

@tdaly61
Copy link
Collaborator

tdaly61 commented Jul 8, 2024

hi @Abhinavcode13 , @elijah0kello , I think we definitely want this instrumentation and looking at how it is done I think makes sense BUT please @Abhinavcode13 , can you please raise this pr against dev not master branch

@Abhinavcode13 Abhinavcode13 changed the title Add monitorResources, measureTime, and Cleanup Enhancements to Mojafos Scripts [24] - Add monitorResources, measureTime, and Cleanup Enhancements to Mojafos Scripts Jul 10, 2024
@elijah0kello
Copy link
Collaborator

elijah0kello commented Jul 23, 2024

Kindly rebase from dev and see if the issue gets fixed then create the PR to dev.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add instrumentation to Mojafos for memory,disk use deploy time taken etc

3 participants

@Abhinavcode13 @elijah0kello @tdaly61