Proper chat_id lookup #403
Open
+195
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chat_id in body is nested under metadata
|
Hi, there is a typo in line 111. Changing 'chat_tracesy' to 'chat_traces' will make it work properly. |
marcklingen
reviewed
Jan 23, 2025
|
@M4g3dd0 did you test this? With the typo this should not have worked |
|
Not this exact code. I was cleaning it up prior to posting here and did not test this final version. Sorry, my bad. |
|
What is preventing this PR from going through? Happy to help DevOps Wizard here 🧙♂️ |
|
We are waiting for review and merge by @tjbck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"chat_id" is nested under "metadata", in gpt4 models, I assume, it can be under "metadata"{"task_body"}. I did not encounter "chat_id" directly in body yet, so I have added checks for it in those three places. And added generation of "chat_id" in case it is missing. And it is missing always, if you try to use openwebui api for model interaction.