Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hpa, resource_quota, replication_controller k8s attributes #1742

Merged
merged 9 commits into from
Jan 29, 2025

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jan 14, 2025

Fixes #1656

Changes

Adds the following k8s resources:

Merge requirement checklist

@ChrsMark ChrsMark force-pushed the add_k8s_resources branch 5 times, most recently from 262c68b to ee73ae5 Compare January 14, 2025 15:35
@ChrsMark ChrsMark marked this pull request as ready for review January 14, 2025 15:36
@ChrsMark ChrsMark requested review from a team as code owners January 14, 2025 15:36
@ChrsMark ChrsMark self-assigned this Jan 15, 2025
model/k8s/registry.yaml Outdated Show resolved Hide resolved
@ChrsMark
Copy link
Member Author

Based on the discussions from #1742 (comment) I have followed the K8s single word approach for referring to resources. Let me know what you think.

If we agree on this we will need a follow-up issue to fix the related metrics' names as well.

model/k8s/registry.yaml Outdated Show resolved Hide resolved
.chloggen/add_k8s_resources.yaml Outdated Show resolved Hide resolved
@lmolkova lmolkova merged commit b865f63 into open-telemetry:main Jan 29, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add k8s resource attributes used by the Collector
7 participants