-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hpa, resource_quota, replication_controller k8s attributes #1742
Merged
+215
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrsMark
force-pushed
the
add_k8s_resources
branch
5 times, most recently
from
January 14, 2025 15:35
262c68b
to
ee73ae5
Compare
TylerHelmuth
approved these changes
Jan 14, 2025
dashpole
approved these changes
Jan 16, 2025
ChrsMark
force-pushed
the
add_k8s_resources
branch
from
January 22, 2025 10:25
573a480
to
ec47412
Compare
lmolkova
reviewed
Jan 23, 2025
ChrsMark
force-pushed
the
add_k8s_resources
branch
from
January 24, 2025 10:01
ec47412
to
595f157
Compare
Based on the discussions from #1742 (comment) I have followed the K8s single word approach for referring to resources. Let me know what you think. If we agree on this we will need a follow-up issue to fix the related metrics' names as well. |
lmolkova
reviewed
Jan 24, 2025
lmolkova
reviewed
Jan 24, 2025
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
ChrsMark
force-pushed
the
add_k8s_resources
branch
from
January 27, 2025 08:36
ac8c15b
to
6f02b77
Compare
lmolkova
approved these changes
Jan 28, 2025
Co-authored-by: Liudmila Molkova <[email protected]>
AlexanderWert
approved these changes
Jan 28, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1656
Changes
Adds the following k8s resources:
k8s.hpa.{name,uid}
: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/a49008324b95f428d518cb4372e2002adf9564b1/receiver/k8sclusterreceiver/metadata.yaml#L140-L148k8s.replication_controller.{name,uid}
: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/a49008324b95f428d518cb4372e2002adf9564b1/receiver/k8sclusterreceiver/metadata.yaml#L80-L88k8s.resource_quota.{name,uid}
: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/v0.115.0/receiver/k8sclusterreceiver/metadata.yaml#L90-L98Merge requirement checklist
[chore]