Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conventions for CLI Spans #1588

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Add conventions for CLI Spans #1588

wants to merge 16 commits into from

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Nov 18, 2024 •
edited
Loading

Fixes #1577

Changes

Start implements semantic conventions for CLI apps.

Merge requirement checklist

@xrmx xrmx requested review from a team as code owners November 18, 2024 10:35
@xrmx xrmx marked this pull request as draft November 18, 2024 10:35
xrmx
xrmx commented Nov 18, 2024
View reviewed changes
model/cli/spans.yaml Outdated Show resolved Hide resolved
xrmx
xrmx commented Nov 18, 2024
View reviewed changes
model/cli/spans.yaml Outdated Show resolved Hide resolved
xrmx
xrmx commented Nov 18, 2024
View reviewed changes
docs/cli/cli-spans.md Outdated Show resolved Hide resolved
docs/cli/cli-spans.md Outdated Show resolved Hide resolved
@xrmx xrmx mentioned this pull request Nov 18, 2024
Open
11 tasks
codefromthecrypt
codefromthecrypt approved these changes Nov 19, 2024
View reviewed changes
Copy link

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Only minor point is if it is worthwhile recording process.executable.path as sometimes that can disambiguate what's being run.

lmolkova
lmolkova reviewed Nov 19, 2024
View reviewed changes
model/cli/spans.yaml Outdated Show resolved Hide resolved
lmolkova
lmolkova reviewed Nov 19, 2024
View reviewed changes
model/cli/spans.yaml Show resolved Hide resolved
model/cli/spans.yaml Outdated Show resolved Hide resolved
model/cli/spans.yaml Show resolved Hide resolved
model/cli/spans.yaml Outdated Show resolved Hide resolved
docs/cli/cli-spans.md Outdated Show resolved Hide resolved
docs/cli/cli-spans.md Outdated Show resolved Hide resolved
docs/cli/cli-spans.md Show resolved Hide resolved
@xrmx xrmx changed the title WIP CLI Spans Add conventions for CLI Spans Nov 20, 2024
xrmx
xrmx commented Nov 20, 2024
View reviewed changes
model/cli/spans.yaml Outdated Show resolved Hide resolved
lmolkova
lmolkova reviewed Nov 20, 2024
View reviewed changes
docs/cli/cli-spans.md Outdated Show resolved Hide resolved
lmolkova
lmolkova reviewed Nov 20, 2024
View reviewed changes
docs/cli/cli-spans.md Outdated Show resolved Hide resolved
lmolkova
lmolkova approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments, LGTM otherwise!

@xrmx xrmx marked this pull request as ready for review November 21, 2024 08:38
@xrmx xrmx requested a review from lmolkova November 21, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

@lzchen lzchen lzchen approved these changes

@tammy-baylis-swi tammy-baylis-swi Awaiting requested review from tammy-baylis-swi

@lmolkova lmolkova Awaiting requested review from lmolkova

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Semantic Conventions Triage
Status: Needs More Approval
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Semconv for cli command executions
5 participants
@xrmx @codefromthecrypt @lmolkova @lzchen @tammy-baylis-swi