Cosmos DB: Network Level Metrics #1543
Open
+617
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
force-pushed
the
users/sourabhjain/networklevelmetrics
branch
from
1f67275
to
f7bbc13
Compare
lmolkova
reviewed
Nov 6, 2024
3 tasks
sourabh1007
force-pushed
the
users/sourabhjain/networklevelmetrics
branch
from
db16caa
to
71ba6d9
Compare
Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
sourabh1007
force-pushed
the
users/sourabhjain/networklevelmetrics
branch
from
6592787
to
762190b
Compare
sourabh1007
force-pushed
the
users/sourabhjain/networklevelmetrics
branch
from
fe03b44
to
0926a76
Compare
FabianMeiswinkel
suggested changes
Nov 21, 2024
| | [`db.cosmosdb.network.response.status_code`](/docs/attributes-registry/db.md) | int | The status code returned in response. [2] | `200` | `Conditionally Required` If available |  | | ||
| | [`db.cosmosdb.network.response.sub_status_code`](/docs/attributes-registry/db.md) | int | The Azure Cosmos DB sub-status code for a network request made during an operation. | `1002` | `Conditionally Required` If available |  | | ||
| | [`db.cosmosdb.sub_status_code`](/docs/attributes-registry/db.md) | int | The Azure Cosmos DB sub-status code for an operation represents the final sub-status code after multiple network interactions have been completed during the operation. | `1000`; `1002` | `Conditionally Required` when response was received and contained sub-code. |  | | ||
| | [`db.namespace`](/docs/attributes-registry/db.md) | string | The name of the database, fully qualified within the server address and port. | `customers`; `test.users` | `Conditionally Required` If available. |  | |
There was a problem hiding this comment.
I still think you are missing a place to capture the CosmosDBAccountName
IMO teh namespace should be a concatenation of Account and Database
Why? The server-addresss (the Gateway endpoint maps to DocuemtnServiceId) - it is the DNS-name for an account - this can be different and not be prefixed with CosmsoDBAccount - it is not super common - but technically those are two different settings - and there are real accounts where server-address does not start with account name - and given that any support/debugging will need the account name, I think emitting this would be needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ref. #1495
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]