-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user_agent.synthetic.type
attribute
#1523
Merged
lmolkova
merged 31 commits into
open-telemetry:main
from
JacksonWeber:jacksonweber-sythetic-source
Nov 22, 2024
Merged
Add user_agent.synthetic.type
attribute
#1523
lmolkova
merged 31 commits into
open-telemetry:main
from
JacksonWeber:jacksonweber-sythetic-source
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Oct 28, 2024
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
lmolkova
reviewed
Nov 1, 2024
Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
…ksonWeber/semantic-conventions into jacksonweber-sythetic-source
jsuereth
reviewed
Nov 4, 2024
trask
reviewed
Nov 19, 2024
lmolkova
reviewed
Nov 19, 2024
…ribute. Co-authored-by: Liudmila Molkova <[email protected]>
lmolkova
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jsuereth
approved these changes
Nov 20, 2024
trask
reviewed
Nov 20, 2024
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
trask
approved these changes
Nov 21, 2024
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
Co-authored-by: Trask Stalnaker <[email protected]>
@JacksonWeber can you check the CI failures? feel free to ping me if you need any help with them |
trask
changed the title
add
Add Nov 22, 2024
http.request.synthetic
attribute to server spans and metricsuser_agent.synthetic.type
attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1127
Changes
Adds the
http.request.synthetic
attribute to server spans and metrics to track if telemetry is generated from a synthetic testing source, some kind of bot, or a real user. This will help users filter out telemetry generated by these kinds of synthetic sources that they may not want to consider.Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]