Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user_agent.synthetic.type attribute #1523

Merged

Conversation

JacksonWeber
Copy link
Contributor

@JacksonWeber JacksonWeber commented Oct 28, 2024

Fixes #1127

Changes

Adds the http.request.synthetic attribute to server spans and metrics to track if telemetry is generated from a synthetic testing source, some kind of bot, or a real user. This will help users filter out telemetry generated by these kinds of synthetic sources that they may not want to consider.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

@JacksonWeber JacksonWeber requested review from a team as code owners October 28, 2024 20:56
model/http/registry.yaml Outdated Show resolved Hide resolved
model/http/registry.yaml Outdated Show resolved Hide resolved
model/http/registry.yaml Outdated Show resolved Hide resolved
.chloggen/add-synthetic-source.yaml Outdated Show resolved Hide resolved
.chloggen/add-synthetic-source.yaml Outdated Show resolved Hide resolved
model/user-agent/registry.yaml Outdated Show resolved Hide resolved
model/user-agent/registry.yaml Outdated Show resolved Hide resolved
model/user-agent/registry.yaml Outdated Show resolved Hide resolved
model/user-agent/registry.yaml Outdated Show resolved Hide resolved
model/user-agent/registry.yaml Outdated Show resolved Hide resolved
model/user-agent/registry.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/http/http-metrics.md Outdated Show resolved Hide resolved
model/http/spans.yaml Show resolved Hide resolved
model/http/spans.yaml Show resolved Hide resolved
.chloggen/add-synthetic-source.yaml Outdated Show resolved Hide resolved
model/user-agent/registry.yaml Outdated Show resolved Hide resolved
.chloggen/add-synthetic-source.yaml Outdated Show resolved Hide resolved
model/http/spans.yaml Outdated Show resolved Hide resolved
model/user-agent/registry.yaml Outdated Show resolved Hide resolved
@trask
Copy link
Member

trask commented Nov 21, 2024

@JacksonWeber can you check the CI failures? feel free to ping me if you need any help with them

@lmolkova lmolkova merged commit c28e251 into open-telemetry:main Nov 22, 2024
14 checks passed
@trask trask changed the title add http.request.synthetic attribute to server spans and metrics Add user_agent.synthetic.type attribute Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Introduction of a Synthetic Attribute for Server Span Telemetry
4 participants