[demo] - clarify demo upgrade capability in Kubernetes #5655
+43
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svrnm
reviewed
Nov 21, 2024
Comment on lines
35
to
37
| > **Note** The OpenTelemetry Demo Helm chart does not support being upgraded | ||
| > from one version to another. If you need to upgrade the chart, you must first | ||
| > delete the existing release and then install the new version. |
There was a problem hiding this comment.
Suggested change
| > **Note** The OpenTelemetry Demo Helm chart does not support being upgraded | |
| > from one version to another. If you need to upgrade the chart, you must first | |
| > delete the existing release and then install the new version. | |
| {{% alert title="Note" color="info" %}} | |
| The OpenTelemetry Demo Helm chart does not support being upgraded | |
| from one version to another. If you need to upgrade the chart, you must first | |
| delete the existing release and then install the new version. | |
| {{% /alert %}} |
we prefer to make use of the docsy shortcode for alerts, since it gives us more flexibility in styling
There was a problem hiding this comment.
I updated this note, and all other notes in this file to use the docsy shortcode
Co-authored-by: Juliano Costa <[email protected]>
tiffany76
approved these changes
Nov 22, 2024
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the demo is started in a Kubernetes world, we use init-containers to ensure the order of services to be started (e.g., Kafka before fraud detection). However, when upgrading the demo, the order in which services are restarted can not be guaranteed. Because of this, the demo install in Kubernetes has never supported an upgrade operation, and this PR adds a note to clarify that.